Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Unified Diff: ios/web/navigation/navigation_manager_storage_builder.mm

Issue 2672953005: Updated ownership of NavigationItems within CRWSessionController. (Closed)
Patch Set: fix unittests Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/navigation/navigation_item_impl_list.mm ('k') | ios/web/public/navigation_item_list.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/navigation/navigation_manager_storage_builder.mm
diff --git a/ios/web/navigation/navigation_manager_storage_builder.mm b/ios/web/navigation/navigation_manager_storage_builder.mm
index 82da72bc3c2d08b047972dce595b66dc0d6726b9..a039ec8753f7a45133d6c7da486121ab928d29f0 100644
--- a/ios/web/navigation/navigation_manager_storage_builder.mm
+++ b/ios/web/navigation/navigation_manager_storage_builder.mm
@@ -54,8 +54,7 @@ @interface CRWSessionController (ExposedForSerialization)
NSMutableArray* item_storages = [[NSMutableArray alloc] init];
NavigationItemStorageBuilder item_storage_builder;
for (size_t index = 0; index < session_controller.items.size(); ++index) {
- web::NavigationItemImpl* item =
- static_cast<web::NavigationItemImpl*>(session_controller.items[index]);
+ web::NavigationItemImpl* item = session_controller.items[index].get();
[item_storages addObject:item_storage_builder.BuildStorage(item)];
}
serialized_navigation_manager.itemStorages = item_storages;
« no previous file with comments | « ios/web/navigation/navigation_item_impl_list.mm ('k') | ios/web/public/navigation_item_list.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698