Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Unified Diff: ios/web/navigation/crw_session_entry.h

Issue 2672953005: Updated ownership of NavigationItems within CRWSessionController. (Closed)
Patch Set: fix unittests Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/navigation/crw_session_controller_unittest.mm ('k') | ios/web/navigation/crw_session_entry.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/navigation/crw_session_entry.h
diff --git a/ios/web/navigation/crw_session_entry.h b/ios/web/navigation/crw_session_entry.h
index 1251d34f6596908d886a79dac06838fb39ea06cd..f584712fde61cb467f768d6d01315e6fff1c72a0 100644
--- a/ios/web/navigation/crw_session_entry.h
+++ b/ios/web/navigation/crw_session_entry.h
@@ -8,8 +8,6 @@
#import <Foundation/Foundation.h>
#include <stdint.h>
-#include <memory>
-
#include "base/strings/string16.h"
#include "base/time/time.h"
#include "ui/base/page_transition_types.h"
@@ -27,7 +25,7 @@ class NavigationItemImpl;
// DEPRECATED, do not use this class and do not add any methods to it.
// Use web::NavigationItem instead.
// TODO(crbug.com/454984): Remove this class.
-@interface CRWSessionEntry : NSObject<NSCopying>
+@interface CRWSessionEntry : NSObject
// Pointer to the NavigationItem associated with this CRWSessionEntry.
// Eventually, this will replace CRWSessionEntry entirely.
@@ -37,8 +35,7 @@ class NavigationItemImpl;
@property(nonatomic, readonly) web::NavigationItemImpl* navigationItemImpl;
// Initialize the session entry with the given NavigationItem.
-- (instancetype)initWithNavigationItem:
- (std::unique_ptr<web::NavigationItem>)item;
+- (instancetype)initWithNavigationItem:(web::NavigationItem*)item;
@end
« no previous file with comments | « ios/web/navigation/crw_session_controller_unittest.mm ('k') | ios/web/navigation/crw_session_entry.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698