Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(46)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: ios/web/public/navigation_item_list.mm
Issue
2672953005
:
Updated ownership of NavigationItems within CRWSessionController. (Closed)
Patch Set: fix unittests
Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
ios/chrome/browser/ui/history/tab_history_popup_controller_unittest.mm
ios/web/BUILD.gn
ios/web/navigation/crw_session_controller.h
ios/web/navigation/crw_session_controller.mm
ios/web/navigation/crw_session_controller_unittest.mm
ios/web/navigation/crw_session_entry.h
ios/web/navigation/crw_session_entry.mm
ios/web/navigation/crw_session_entry_unittest.mm
ios/web/navigation/navigation_item_impl_list.h
ios/web/navigation/navigation_item_impl_list.mm
ios/web/navigation/navigation_manager_storage_builder.mm
ios/web/public/navigation_item_list.h
ios/web/public/navigation_item_list.mm
ios/web/web_state/ui/crw_web_controller_unittest.mm
View unified diff
|
Download patch
« no previous file with comments
|
« ios/web/public/navigation_item_list.h
('k') |
ios/web/web_state/ui/crw_web_controller_unittest.mm »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
// Copyright 2017 The Chromium Authors. All rights reserved.
2
// Use of this source code is governed by a BSD-style license that can be
3
// found in the LICENSE file.
4
5
#import "ios/web/public/navigation_item_list.h"
6
7
namespace web {
8
9
NavigationItemList CreateRawNavigationItemList(
10
const ScopedNavigationItemList& scoped_list) {
11
NavigationItemList list(scoped_list.size());
12
for (size_t index = 0; index < scoped_list.size(); ++index)
13
list[index] = scoped_list[index].get();
14
return list;
15
}
16
17
} // namespace web
OLD
NEW
« no previous file with comments
|
« ios/web/public/navigation_item_list.h
('k') |
ios/web/web_state/ui/crw_web_controller_unittest.mm »
('j') |
no next file with comments »
Issue 2672953005: Updated ownership of NavigationItems within CRWSessionController. (Closed)
Created 3 years, 10 months ago by kkhorimoto
Modified 3 years, 10 months ago
Reviewers: Eugene But (OOO till 7-30)
Base URL:
Comments: 24
This is Rietveld
408576698