Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 267293008: Make nacl_loader_unittests a criteria of LKGR (Closed)

Created:
6 years, 7 months ago by hamaji
Modified:
6 years, 7 months ago
CC:
chromium-reviews, kjellander-cc_chromium.org, cmp-cc_chromium.org, ilevy-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Visibility:
Public.

Description

Make nacl_loader_unittests a criterion of LKGR Also, add sandbox_linux_unittests on 64bit linux tester to the list of LKGR requirements. BUG=364751

Patch Set 1 #

Total comments: 2

Patch Set 2 : add sandbox_linux_unittests to 64bit linux tester #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M scripts/tools/lkgr_finder.py View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hamaji
I've added these tests in chrome/src/testing/buildbot, so now it should work?
6 years, 7 months ago (2014-05-08 00:27:28 UTC) #1
jln (very slow on Chromium)
lgtm. These tests are very reliable, fast and security-critical, so I think they make sense ...
6 years, 7 months ago (2014-05-08 00:39:13 UTC) #2
hamaji
https://codereview.chromium.org/267293008/diff/1/scripts/tools/lkgr_finder.py File scripts/tools/lkgr_finder.py (right): https://codereview.chromium.org/267293008/diff/1/scripts/tools/lkgr_finder.py#newcode261 scripts/tools/lkgr_finder.py:261: 'sql_unittests', On 2014/05/08 00:39:13, jln wrote: > Hmmm, sandbox_linux_unittests ...
6 years, 7 months ago (2014-05-08 01:42:56 UTC) #3
agable
On 2014/05/08 01:42:56, hamaji wrote: > https://codereview.chromium.org/267293008/diff/1/scripts/tools/lkgr_finder.py > File scripts/tools/lkgr_finder.py (right): > > https://codereview.chromium.org/267293008/diff/1/scripts/tools/lkgr_finder.py#newcode261 > ...
6 years, 7 months ago (2014-05-12 15:50:33 UTC) #4
hamaji
6 years, 7 months ago (2014-05-13 11:18:09 UTC) #5

Powered by Google App Engine
This is Rietveld 408576698