New analyzer snapshot.

pkg/analyzer/lib/src/generated/constant.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // This code was auto-generated, is not intended to be edited, and is subject to
 // significant change. Please see the README file for more information.
 
 library engine.constant;
 
 import 'java_core.dart';
@@ skipping 538 matching lines @@
         Expression argument = arguments[i];
         if (argument is NamedExpression) {
           NamedExpression namedExpression = argument;
           String name = namedExpression.name.label.name;
           namedArgumentValues[name] = _valueOf(namedExpression.expression);
           argumentValues[i] = null2;
         } else {
           argumentValues[i] = _valueOf(argument);
         }
       }
+      Set<ConstructorElement> constructorsVisited = new Set<ConstructorElement>();
       InterfaceType definingClass = constructor.returnType as InterfaceType;
-      if (definingClass.element.library.isDartCore) {
-        String className = definingClass.name;
-        if (className == "Symbol" && argumentCount == 1) {
-          String argumentValue = argumentValues[0].stringValue;
-          if (argumentValue != null) {
-            return _valid(definingClass, new SymbolState(argumentValue));
+      while (constructor.isFactory) {
+        if (definingClass.element.library.isDartCore) {
+          String className = definingClass.name;
+          if (className == "Symbol" && argumentCount == 1) {
+            String argumentValue = argumentValues[0].stringValue;
+            if (argumentValue != null) {
+              return _valid(definingClass, new SymbolState(argumentValue));
+            }
           }
         }
+        constructorsVisited.add(constructor);
+        ConstructorElement redirectedConstructor = constructor.redirectedConstructor;
+        if (redirectedConstructor == null) {
+          // This can happen if constructor is an external factory constructor.  Since there is no
+          // constructor to delegate to, we currently can't evaluate the constant.
+          // TODO(paulberry): if the constructor is one of {bool,int,String}.fromEnvironment(),
+          // we may be able to infer the value based on -D flags provided to the analyzer (see
+          // dartbug.com/17234).
+          return _error(node, null);
+        }
+        if (!redirectedConstructor.isConst) {
+          // Delegating to a non-const constructor--this is not allowed (and
+          // is checked elsewhere--see [ErrorVerifier.checkForRedirectToNonConstConstructor()]).
+          // So if we encounter it just error out.
+          return _error(node, null);
+        }
+        if (constructorsVisited.contains(redirectedConstructor)) {
+          // Cycle in redirecting factory constructors--this is not allowed
+          // and is checked elsewhere--see [ErrorVerifier.checkForRecursiveFactoryRedirect()]).
+          // So if we encounter it just error out.
+          return _error(node, null);
+        }
+        constructor = redirectedConstructor;
+        definingClass = constructor.returnType as InterfaceType;
       }
       Map<String, DartObjectImpl> fieldMap = new Map<String, DartObjectImpl>();
       List<ParameterElement> parameters = constructor.parameters;
       int parameterCount = parameters.length;
       for (int i = 0; i < parameterCount; i++) {
         ParameterElement parameter = parameters[i];
         if (parameter.isInitializingFormal) {
           FieldElement field = (parameter as FieldFormalParameterElement).field;
           if (field != null) {
             String fieldName = field.name;
@@ skipping 3751 matching lines @@
   ErrorResult _error(AstNode node, ErrorCode code) => new ErrorResult.con1(node, code);
 
   /**
    * Return a result object representing the given value.
    *
    * @param value the value to be represented as a result object
    * @return a result object representing the given value
    */
   ValidResult _valueOf(DartObjectImpl value) => new ValidResult(value);
 }