Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 267293004: Wires up view manager to an actual display (Closed)

Created:
6 years, 7 months ago by sky
Modified:
6 years, 7 months ago
CC:
chromium-reviews, ben+aura_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, sadrul, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 4

Patch Set 3 : integrate feedback #

Patch Set 4 : merge 2 trunk #

Patch Set 5 : deps #

Patch Set 6 : revert #

Patch Set 7 : fix #

Patch Set 8 : merge again #

Patch Set 9 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+522 lines, -117 lines) Patch
M mojo/mojo.gyp View 1 2 3 4 5 6 7 8 2 chunks +8 lines, -0 lines 0 comments Download
M mojo/mojo_examples.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/mojo_services.gypi View 1 2 3 4 5 6 7 8 5 chunks +35 lines, -3 lines 0 comments Download
M mojo/services/native_viewport/native_viewport_service.cc View 1 chunk +5 lines, -1 line 0 comments Download
A mojo/services/public/cpp/view_manager/lib/DEPS View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
A mojo/services/public/cpp/view_manager/lib/view_manager_test_suite.h View 1 2 3 4 1 chunk +30 lines, -0 lines 0 comments Download
A + mojo/services/public/cpp/view_manager/lib/view_manager_test_suite.cc View 1 2 3 4 1 chunk +9 lines, -7 lines 0 comments Download
A + mojo/services/public/cpp/view_manager/lib/view_manager_unittests.cc View 1 2 3 4 1 chunk +4 lines, -6 lines 0 comments Download
M mojo/services/public/interfaces/view_manager/view_manager.mojom View 1 chunk +5 lines, -0 lines 0 comments Download
M mojo/services/view_manager/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
A + mojo/services/view_manager/main.cc View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M mojo/services/view_manager/node.h View 4 chunks +26 lines, -1 line 0 comments Download
M mojo/services/view_manager/node.cc View 1 3 chunks +71 lines, -3 lines 0 comments Download
M mojo/services/view_manager/root_node_manager.h View 7 chunks +21 lines, -15 lines 0 comments Download
M mojo/services/view_manager/root_node_manager.cc View 4 chunks +15 lines, -16 lines 0 comments Download
A mojo/services/view_manager/root_view_manager.h View 1 1 chunk +66 lines, -0 lines 0 comments Download
A mojo/services/view_manager/root_view_manager.cc View 1 2 1 chunk +90 lines, -0 lines 0 comments Download
M mojo/services/view_manager/view.h View 3 chunks +5 lines, -0 lines 0 comments Download
M mojo/services/view_manager/view.cc View 1 chunk +8 lines, -0 lines 0 comments Download
D mojo/services/view_manager/view_manager.cc View 1 chunk +0 lines, -32 lines 0 comments Download
M mojo/services/view_manager/view_manager_connection.h View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/services/view_manager/view_manager_connection.cc View 2 chunks +21 lines, -0 lines 0 comments Download
M mojo/shell/context.cc View 2 chunks +1 line, -31 lines 0 comments Download
A mojo/shell/view_manager_loader.h View 1 chunk +46 lines, -0 lines 0 comments Download
A mojo/shell/view_manager_loader.cc View 1 chunk +40 lines, -0 lines 0 comments Download
M ui/aura/window_tree_host.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 20 (0 generated)
sky
6 years, 7 months ago (2014-05-07 03:28:57 UTC) #1
Ben Goodger (Google)
lgtm https://codereview.chromium.org/267293004/diff/20001/mojo/services/view_manager/main.cc File mojo/services/view_manager/main.cc (right): https://codereview.chromium.org/267293004/diff/20001/mojo/services/view_manager/main.cc#newcode11 mojo/services/view_manager/main.cc:11: #include "ui/aura/env.h" ??? https://codereview.chromium.org/267293004/diff/20001/mojo/services/view_manager/root_view_manager.cc File mojo/services/view_manager/root_view_manager.cc (right): https://codereview.chromium.org/267293004/diff/20001/mojo/services/view_manager/root_view_manager.cc#newcode26 ...
6 years, 7 months ago (2014-05-07 17:21:36 UTC) #2
sky
https://codereview.chromium.org/267293004/diff/20001/mojo/services/view_manager/main.cc File mojo/services/view_manager/main.cc (right): https://codereview.chromium.org/267293004/diff/20001/mojo/services/view_manager/main.cc#newcode11 mojo/services/view_manager/main.cc:11: #include "ui/aura/env.h" On 2014/05/07 17:21:36, Ben Goodger (Google) wrote: ...
6 years, 7 months ago (2014-05-07 17:33:22 UTC) #3
sky
The CQ bit was checked by sky@chromium.org
6 years, 7 months ago (2014-05-07 17:33:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/267293004/40001
6 years, 7 months ago (2014-05-07 17:39:56 UTC) #5
sky
I updated this so that view_manager_lib_unittests is run in the same manner as view_manager_unittests. This ...
6 years, 7 months ago (2014-05-08 00:00:17 UTC) #6
Ben Goodger (Google)
lgtm
6 years, 7 months ago (2014-05-08 00:03:22 UTC) #7
sky
The CQ bit was checked by sky@chromium.org
6 years, 7 months ago (2014-05-08 00:04:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/267293004/80001
6 years, 7 months ago (2014-05-08 00:07:49 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-08 18:04:43 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-08 22:45:59 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/13712)
6 years, 7 months ago (2014-05-08 22:45:59 UTC) #12
sky
The CQ bit was checked by sky@chromium.org
6 years, 7 months ago (2014-05-08 22:57:44 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/267293004/80001
6 years, 7 months ago (2014-05-08 23:03:10 UTC) #14
commit-bot: I haz the power
Change committed as 269206
6 years, 7 months ago (2014-05-09 10:21:46 UTC) #15
Paweł Hajdan Jr.
A revert of this CL has been created in https://codereview.chromium.org/275853002/ by phajdan.jr@chromium.org. The reason for ...
6 years, 7 months ago (2014-05-09 10:38:04 UTC) #16
sky
I was reverted because of a gyp issue. It's fixed in latest patch (diff between ...
6 years, 7 months ago (2014-05-09 13:44:11 UTC) #17
sky
Committed patchset #7 manually as r269267 (presubmit successful).
6 years, 7 months ago (2014-05-09 13:51:07 UTC) #18
sky
*SIGH* reverted again. This time because of static build issues. I had to explicitly include ...
6 years, 7 months ago (2014-05-09 16:25:17 UTC) #19
sky
6 years, 7 months ago (2014-05-09 16:29:18 UTC) #20
Message was sent while issue was closed. 
Committed patchset #9 manually as r269322 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698