tools/dom/src/native_DOMImplementation.dart - Issue 26729002: dartium_js_interop changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/src/native_DOMImplementation.dart

Issue 26729002: dartium_js_interop changes Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: ready for review Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/dom/src/native_DOMImplementation.dart

diff --git a/tools/dom/src/native_DOMImplementation.dart b/tools/dom/src/native_DOMImplementation.dart

index 38956acce395564bff0f575e0138a21a1a5544e5..4b37a62538564657dae3d9577d0c5f5985c04764 100644

--- a/tools/dom/src/native_DOMImplementation.dart

+++ b/tools/dom/src/native_DOMImplementation.dart

@@ -385,10 +385,6 @@ class _Utils {

static bool isNoSuchMethodError(obj) => obj is NoSuchMethodError;

- // TODO(jacobr): we need a failsafe way to determine that a Node is really a

- // DOM node rather than just a class that extends Node.

- static bool isNode(obj) => obj is Node;

static bool _isBuiltinType(ClassMirror cls) {

// TODO(vsm): Find a less hackish way to do this.

LibraryMirror lib = cls.owner;