Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2672843003: Re-submit Range.toString() and test status changes (Closed)

Created:
3 years, 10 months ago by Alan Knight
Modified:
3 years, 10 months ago
Reviewers:
terry, Bill Hesse
CC:
reviews_dartlang.org, asgerf
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -47 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/co19/co19-dart2js.status View 13 chunks +0 lines, -47 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Range.darttemplate View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Alan Knight
3 years, 10 months ago (2017-02-03 00:03:20 UTC) #3
Bill Hesse
LGTM
3 years, 10 months ago (2017-02-03 00:26:16 UTC) #4
Alan Knight
3 years, 10 months ago (2017-02-03 17:56:04 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
95d409e3ed651a630b0166bd69216495c1cd8c0c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698