Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: Source/core/html/shadow/SpinButtonElement.h

Issue 267283007: Oilpan: Prepare to move form control ua shadow elements to Oilpan heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/shadow/SpinButtonElement.h
diff --git a/Source/core/html/shadow/SpinButtonElement.h b/Source/core/html/shadow/SpinButtonElement.h
index 231b2200093fbcbf184c73171be99210fce7d5c3..d29fdbe4b47010e07ddf76e644715a0f83a7c24b 100644
--- a/Source/core/html/shadow/SpinButtonElement.h
+++ b/Source/core/html/shadow/SpinButtonElement.h
@@ -44,7 +44,7 @@ public:
EventDispatchAllowed,
EventDispatchDisallowed,
};
- class SpinButtonOwner {
+ class SpinButtonOwner : public WillBeGarbageCollectedMixin {
public:
virtual ~SpinButtonOwner() { }
virtual void focusAndSelectSpinButtonOwner() = 0;
@@ -61,7 +61,7 @@ public:
static PassRefPtr<SpinButtonElement> create(Document&, SpinButtonOwner&);
UpDownState upDownState() const { return m_upDownState; }
void releaseCapture(EventDispatch = EventDispatchAllowed);
- void removeSpinButtonOwner() { m_spinButtonOwner = 0; }
+ void removeSpinButtonOwner() { m_spinButtonOwner = nullptr; }
void step(int amount);
@@ -70,6 +70,8 @@ public:
void forwardEvent(Event*);
+ virtual void trace(Visitor*) OVERRIDE;
+
private:
SpinButtonElement(Document&, SpinButtonOwner&);
@@ -88,7 +90,7 @@ private:
bool shouldRespondToMouseEvents();
virtual bool isMouseFocusable() const OVERRIDE { return false; }
- SpinButtonOwner* m_spinButtonOwner;
+ RawPtrWillBeMember<SpinButtonOwner> m_spinButtonOwner;
bool m_capturing;
UpDownState m_upDownState;
UpDownState m_pressStartingState;

Powered by Google App Engine
This is Rietveld 408576698