public/platform/WebGraphicsContext3D.h - Issue 267283003: Cleanup change to the createImageCHROMIUM api to follow up https://codereview.chromium.org/25571300…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/platform/WebGraphicsContext3D.h

Issue 267283003: Cleanup change to the createImageCHROMIUM api to follow up https://codereview.chromium.org/25571300… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: public/platform/WebGraphicsContext3D.h

diff --git a/public/platform/WebGraphicsContext3D.h b/public/platform/WebGraphicsContext3D.h

index c0b08c9daed57127efdd8a684824d592fe455b38..ec2a43b002a289b2138f1b411b1e1de3b9899003 100644

--- a/public/platform/WebGraphicsContext3D.h

+++ b/public/platform/WebGraphicsContext3D.h

@@ -455,10 +455,10 @@ public:

virtual GrGLInterface* createGrGLInterface() { return 0; }

// GL_CHROMIUM_map_image

- virtual WGC3Duint createImageCHROMIUM(WGC3Dsizei width, WGC3Dsizei height, WGC3Denum internalformat) { return 0; }

+ virtual WGC3Duint createImageCHROMIUM(WGC3Dsizei width, WGC3Dsizei height, WGC3Denum internalformat, WGC3Denum usage) { return 0; }

virtual void destroyImageCHROMIUM(WGC3Duint imageId) { }

virtual void getImageParameterivCHROMIUM(WGC3Duint imageId, WGC3Denum pname, WGC3Dint* params) { }

- virtual void* mapImageCHROMIUM(WGC3Duint imageId, WGC3Denum access) { return 0; }

+ virtual void* mapImageCHROMIUM(WGC3Duint imageId) { return 0; }

virtual void unmapImageCHROMIUM(WGC3Duint imageId) { }

// GL_ANGLE_instanced_arrays

« no previous file with comments | « no previous file | no next file » | no next file with comments »