Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp

Issue 2672823006: Add UseCounter to see how often the "allowfullscreen" attribute is modified. (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Simon Hausmann (hausmann@kde.org) 4 * (C) 2000 Simon Hausmann (hausmann@kde.org)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * Copyright (C) 2004, 2006, 2008, 2009 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2006, 2008, 2009 Apple Inc. All rights reserved.
7 * Copyright (C) 2009 Ericsson AB. All rights reserved. 7 * Copyright (C) 2009 Ericsson AB. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
118 m_referrerPolicy = ReferrerPolicyDefault; 118 m_referrerPolicy = ReferrerPolicyDefault;
119 if (!value.isNull()) { 119 if (!value.isNull()) {
120 SecurityPolicy::referrerPolicyFromString( 120 SecurityPolicy::referrerPolicyFromString(
121 value, SupportReferrerPolicyLegacyKeywords, &m_referrerPolicy); 121 value, SupportReferrerPolicyLegacyKeywords, &m_referrerPolicy);
122 UseCounter::count(document(), 122 UseCounter::count(document(),
123 UseCounter::HTMLIFrameElementReferrerPolicyAttribute); 123 UseCounter::HTMLIFrameElementReferrerPolicyAttribute);
124 } 124 }
125 } else if (name == allowfullscreenAttr) { 125 } else if (name == allowfullscreenAttr) {
126 bool oldAllowFullscreen = m_allowFullscreen; 126 bool oldAllowFullscreen = m_allowFullscreen;
127 m_allowFullscreen = !value.isNull(); 127 m_allowFullscreen = !value.isNull();
128 if (m_allowFullscreen != oldAllowFullscreen) 128 if (m_allowFullscreen != oldAllowFullscreen) {
129 // TODO(iclelland): Remove this use counter when the allowfullscreen
130 // attribute state is snapshotted on document creation. crbug.com/682282
131 if (m_allowFullscreen && contentFrame()) {
132 UseCounter::count(
133 document(),
134 UseCounter::
135 HTMLIFrameElementAllowfullscreenAttributeSetAfterContentLoad);
136 }
129 frameOwnerPropertiesChanged(); 137 frameOwnerPropertiesChanged();
138 }
130 } else if (name == allowpaymentrequestAttr) { 139 } else if (name == allowpaymentrequestAttr) {
131 bool oldAllowPaymentRequest = m_allowPaymentRequest; 140 bool oldAllowPaymentRequest = m_allowPaymentRequest;
132 m_allowPaymentRequest = !value.isNull(); 141 m_allowPaymentRequest = !value.isNull();
133 if (m_allowPaymentRequest != oldAllowPaymentRequest) 142 if (m_allowPaymentRequest != oldAllowPaymentRequest)
134 frameOwnerPropertiesChanged(); 143 frameOwnerPropertiesChanged();
135 } else if (name == permissionsAttr) { 144 } else if (name == permissionsAttr) {
136 if (initializePermissionsAttribute()) 145 if (initializePermissionsAttribute())
137 m_permissions->setValue(value); 146 m_permissions->setValue(value);
138 } else if (RuntimeEnabledFeatures::embedderCSPEnforcementEnabled() && 147 } else if (RuntimeEnabledFeatures::embedderCSPEnforcementEnabled() &&
139 name == cspAttr) { 148 name == cspAttr) {
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
218 bool HTMLIFrameElement::initializePermissionsAttribute() { 227 bool HTMLIFrameElement::initializePermissionsAttribute() {
219 if (!RuntimeEnabledFeatures::permissionDelegationEnabled()) 228 if (!RuntimeEnabledFeatures::permissionDelegationEnabled())
220 return false; 229 return false;
221 230
222 if (!m_permissions) 231 if (!m_permissions)
223 m_permissions = HTMLIFrameElementPermissions::create(this); 232 m_permissions = HTMLIFrameElementPermissions::create(this);
224 return true; 233 return true;
225 } 234 }
226 235
227 } // namespace blink 236 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/frame/UseCounter.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698