Add UseCounter to see how often the "allowfullscreen" attribute is modified.

third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Simon Hausmann (hausmann@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2006, 2008, 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2009 Ericsson AB. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 107 matching lines @@
     m_referrerPolicy = ReferrerPolicyDefault;
     if (!value.isNull()) {
       SecurityPolicy::referrerPolicyFromStringWithLegacyKeywords(
           value, &m_referrerPolicy);
       UseCounter::count(document(),
                         UseCounter::HTMLIFrameElementReferrerPolicyAttribute);
     }
   } else if (name == allowfullscreenAttr) {
     bool oldAllowFullscreen = m_allowFullscreen;
     m_allowFullscreen = !value.isNull();
-    if (m_allowFullscreen != oldAllowFullscreen)
+    if (m_allowFullscreen != oldAllowFullscreen) {
+      if (contentFrame()) {

[foolip, 2017/02/05 23:22:08]

I believe this means roughly "has this iframe loaded", but does the null-ness of
contentFrame() change at exactly the time that feature policy and sanbox
attributes are snapshotted?

I have no reason to suspect that it'd inflate the numbers, but this counter also
includes a case where the allowfullscreen attribute is removed after load. Don't
know why you'd do that, but interwebs are full of surprises.

[iclelland, 2017/02/06 20:15:25]

Sandbox attributes are snapshotted in |WebLocalFrameImpl::createChildFrame,
immediately before |WebLocalFrameImpl::initializeCoreFrame| is called. During
that method, the |m_contentFrame| member is set (through LocalFrame::create.)

|m_contentFrame| is nulled when the frame is detached from the document. If
reattached, the new frame contents are initialized the same way.

This is not reset on subframe navigation, though, so it won't catch the pattern
of Add Iframe -> Change Attribute -> Navigate -> Request Fullscreen; that will
look like a blocked fullscreen request.
That's deliberate, as it would also be a situation in which snapshotting would
change existing behaviour. (If a site tried to block an otherwise allowed
fullscreen request by removing the attribute)

Both of these issues, I believe, will cause us to overcount the impact of this
change. We could tighten this up, to try to only catch the exact situation where
fullscreen would break, but that should be a strictly smaller number than this
one. I'd like to land this counter, to try to merge to M57, to get as much data
as we can. I'll add the other, tighter use counter in a separate CL if you're
okay with that.

+        UseCounter::count(
+            document(), UseCounter::HTMLIFrameElementAllowfullscreenAttribute);

[foolip, 2017/02/05 23:22:08]

Can you append "ChangedAfterContentLoad" or something like that? People
sometimes go hunting in chromestatus.com for counters to answer a particular
question, and counters cover much more or less than the name suggest can
confuse. (Obviously 100% precision is not reasonable though.)

[iclelland, 2017/02/06 20:15:25]

Done.

+      }
       frameOwnerPropertiesChanged();
+    }
   } else if (name == allowpaymentrequestAttr) {
     bool oldAllowPaymentRequest = m_allowPaymentRequest;
     m_allowPaymentRequest = !value.isNull();
     if (m_allowPaymentRequest != oldAllowPaymentRequest)
       frameOwnerPropertiesChanged();
   } else if (name == permissionsAttr) {
     if (initializePermissionsAttribute())
       m_permissions->setValue(value);
   } else if (RuntimeEnabledFeatures::embedderCSPEnforcementEnabled() &&
              name == cspAttr) {
@@ skipping 78 matching lines @@
 bool HTMLIFrameElement::initializePermissionsAttribute() {
   if (!RuntimeEnabledFeatures::permissionDelegationEnabled())
     return false;
 
   if (!m_permissions)
     m_permissions = HTMLIFrameElementPermissions::create(this);
   return true;
 }
 
 }  // namespace blink