Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2672803003: updated to latest dart2js_info (Closed)

Created:
3 years, 10 months ago by kevmoo
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
kevmoo
3 years, 10 months ago (2017-02-03 01:20:34 UTC) #2
kevmoo
On 2017/02/03 01:20:34, kevmoo wrote: Ran ./tools/test.py -m release dart2js w/ no issues – not ...
3 years, 10 months ago (2017-02-03 01:20:56 UTC) #3
Siggi Cherem (dart-lang)
lgtm
3 years, 10 months ago (2017-02-03 16:51:16 UTC) #4
kevmoo
Committed patchset #1 (id:1) manually as d1be8f8b04024bd0cbfec08088d85fa281efc8a2 (presubmit successful).
3 years, 10 months ago (2017-02-03 16:58:55 UTC) #6
Harry Terkelsen
On 2017/02/03 16:58:55, kevmoo wrote: > Committed patchset #1 (id:1) manually as > d1be8f8b04024bd0cbfec08088d85fa281efc8a2 (presubmit ...
3 years, 10 months ago (2017-02-03 17:19:27 UTC) #7
kevmoo
3 years, 10 months ago (2017-02-03 17:35:41 UTC) #8
Message was sent while issue was closed.
On 2017/02/03 17:19:27, Harry Terkelsen wrote:
> On 2017/02/03 16:58:55, kevmoo wrote:
> > Committed patchset #1 (id:1) manually as
> > d1be8f8b04024bd0cbfec08088d85fa281efc8a2 (presubmit successful).
> 
> you also have to update dartium DEPS

Please - https://codereview.chromium.org/2678483002/

Powered by Google App Engine
This is Rietveld 408576698