content/test/gpu/gpu_tests/trace_integration_test.py - Issue 2672803002: [Telemetry refactor] Migrate clients to new JavaScript API (batch 3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/test/gpu/gpu_tests/trace_integration_test.py

Issue 2672803002: [Telemetry refactor] Migrate clients to new JavaScript API (batch 3) (Closed)

Patch Set: add comment on tools/android Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/test/gpu/gpu_tests/trace_integration_test.py

diff --git a/content/test/gpu/gpu_tests/trace_integration_test.py b/content/test/gpu/gpu_tests/trace_integration_test.py

index 071d427f77bce8e73eb2356db2188898d046ef50..6dfa2cd866ccb3acdfad1a6d70b068bccebfd490 100644

--- a/content/test/gpu/gpu_tests/trace_integration_test.py

+++ b/content/test/gpu/gpu_tests/trace_integration_test.py

@@ -93,8 +93,8 @@ class TraceIntegrationTest(gpu_integration_test.GpuIntegrationTest):

# Perform page navigation.

url = self.UrlOfStaticFilePath(test_path)

tab.Navigate(url, script_to_evaluate_on_commit=test_harness_script)

- tab.action_runner.WaitForJavaScriptCondition(

- 'domAutomationController._finished', timeout_in_seconds=30)

+ tab.action_runner.WaitForJavaScriptCondition2(

+ 'domAutomationController._finished', timeout=30)

# Stop tracing.

timeline_data = tab.browser.platform.tracing_controller.StopTracing()