content/test/gpu/gpu_tests/hardware_accelerated_feature_integration_test.py - Issue 2672803002: [Telemetry refactor] Migrate clients to new JavaScript API (batch 3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/test/gpu/gpu_tests/hardware_accelerated_feature_integration_test.py

Issue 2672803002: [Telemetry refactor] Migrate clients to new JavaScript API (batch 3) (Closed)

Patch Set: add comment on tools/android Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/test/gpu/gpu_tests/gpu_process_integration_test.py ('k') | content/test/gpu/gpu_tests/maps_integration_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/test/gpu/gpu_tests/hardware_accelerated_feature_integration_test.py

diff --git a/content/test/gpu/gpu_tests/hardware_accelerated_feature_integration_test.py b/content/test/gpu/gpu_tests/hardware_accelerated_feature_integration_test.py

index f088b18a5ce72b5abe0643bda5a9aebfff25f479..413c63b48cde62cff48ffb85864222b7748b7302 100644

--- a/content/test/gpu/gpu_tests/hardware_accelerated_feature_integration_test.py

+++ b/content/test/gpu/gpu_tests/hardware_accelerated_feature_integration_test.py

@@ -68,9 +68,10 @@ class HardwareAcceleratedFeatureIntegrationTest(

feature = args[0]

self._Navigate(test_path)

tab = self.tab

- if not tab.EvaluateJavaScript('VerifyHardwareAccelerated("%s")' % feature):

+ if not tab.EvaluateJavaScript2(

+ 'VerifyHardwareAccelerated({{ feature }})', feature=feature):

print 'Test failed. Printing page contents:'

- print tab.EvaluateJavaScript('document.body.innerHTML')

+ print tab.EvaluateJavaScript2('document.body.innerHTML')

self.fail('%s not hardware accelerated' % feature)

def load_tests(loader, tests, pattern):

« no previous file with comments | « content/test/gpu/gpu_tests/gpu_process_integration_test.py ('k') | content/test/gpu/gpu_tests/maps_integration_test.py » ('j') | no next file with comments »