chrome/test/media_router/telemetry/benchmarks/media_router_cpu_memory_metric.py - Issue 2672803002: [Telemetry refactor] Migrate clients to new JavaScript API (batch 3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/media_router/telemetry/benchmarks/media_router_cpu_memory_metric.py

Issue 2672803002: [Telemetry refactor] Migrate clients to new JavaScript API (batch 3) (Closed)

Patch Set: add comment on tools/android Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/media_router/telemetry/benchmarks/media_router_cpu_memory_metric.py

diff --git a/chrome/test/media_router/telemetry/benchmarks/media_router_cpu_memory_metric.py b/chrome/test/media_router/telemetry/benchmarks/media_router_cpu_memory_metric.py

index a552c62cd0bfeca7ba55010b903d3690cfd66d8d..55fabcd3e78d49fede46f6334779aacd05b4e258 100644

--- a/chrome/test/media_router/telemetry/benchmarks/media_router_cpu_memory_metric.py

+++ b/chrome/test/media_router/telemetry/benchmarks/media_router_cpu_memory_metric.py

@@ -27,7 +27,7 @@ class MediaRouterCPUMemoryMetric(Metric):

def AddResults(self, tab, results):

results_json = None

try:

- results_json = tab.EvaluateJavaScript(

+ results_json = tab.EvaluateJavaScript2(

'JSON.stringify(window.perfResults)')

except exceptions.EvaluateException:

pass

@@ -59,4 +59,4 @@ class MediaRouterCPUMemoryMetric(Metric):

len(perf_results['cpu']['browser'])), 2)

results.AddValue(scalar.ScalarValue(

results.current_page, 'mr_extension_wakeup_percentage',

- '%', wakeup_percentage))

+ '%', wakeup_percentage))

« no previous file with comments | « no previous file | chrome/test/media_router/telemetry/benchmarks/pagesets/media_router_page.py » ('j') | no next file with comments »