Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7448)

Unified Diff: chrome/browser/ui/autofill/chrome_autofill_client.cc

Issue 2672623005: Record Autofill form events specially for nonsecure pages (Closed)
Patch Set: rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/chrome_autofill_client.cc
diff --git a/chrome/browser/ui/autofill/chrome_autofill_client.cc b/chrome/browser/ui/autofill/chrome_autofill_client.cc
index 613753281d8638884e2b1fc25b14c55d6e0b3f02..b87210521706928926c01a879f3df538d8ced589 100644
--- a/chrome/browser/ui/autofill/chrome_autofill_client.cc
+++ b/chrome/browser/ui/autofill/chrome_autofill_client.cc
@@ -343,6 +343,10 @@ void ChromeAutofillClient::OnFirstUserGestureObserved() {
}
bool ChromeAutofillClient::IsContextSecure(const GURL& form_origin) {
+ return IsMainUrlSecure();
+}
+
+bool ChromeAutofillClient::IsMainUrlSecure() {
content::SSLStatus ssl_status;
content::NavigationEntry* navigation_entry =
web_contents()->GetController().GetLastCommittedEntry();
@@ -351,7 +355,7 @@ bool ChromeAutofillClient::IsContextSecure(const GURL& form_origin) {
ssl_status = navigation_entry->GetSSL();
// Note: If changing the implementation below, also change
- // AwAutofillClient::IsContextSecure. See crbug.com/505388
+ // AwAutofillClient::IsMainUrlSecure. See crbug.com/505388
return navigation_entry->GetURL().SchemeIsCryptographic() &&
ssl_status.certificate &&
(!net::IsCertStatusError(ssl_status.cert_status) ||

Powered by Google App Engine
This is Rietveld 408576698