components/password_manager/core/browser/password_autofill_manager.cc - Issue 2672623005: Record Autofill form events specially for nonsecure pages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_autofill_manager.cc

Issue 2672623005: Record Autofill form events specially for nonsecure pages (Closed)

Patch Set: fix test added in rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/test_autofill_client.cc ('k') | ios/chrome/browser/autofill/autofill_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_autofill_manager.cc

diff --git a/components/password_manager/core/browser/password_autofill_manager.cc b/components/password_manager/core/browser/password_autofill_manager.cc

index 306f206abd99105342d3e0867dbb1246f3d6bd1f..b66695368640af5b944a0752b36faf8817eac5f5 100644

--- a/components/password_manager/core/browser/password_autofill_manager.cc

+++ b/components/password_manager/core/browser/password_autofill_manager.cc

@@ -219,7 +219,7 @@ void PasswordAutofillManager::OnShowPasswordSuggestions(

}

GURL origin = (fill_data_it->second).origin;

- bool is_context_secure = autofill_client_->IsContextSecure(origin) &&

+ bool is_context_secure = autofill_client_->IsContextSecure() &&

(!origin.is_valid() || !origin.SchemeIs("http"));

if (!is_context_secure && security_state::IsHttpWarningInFormEnabled()) {

std::string icon_str;

« no previous file with comments | « components/autofill/core/browser/test_autofill_client.cc ('k') | ios/chrome/browser/autofill/autofill_controller.mm » ('j') | no next file with comments »