Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: components/autofill/core/browser/autofill_manager.cc

Issue 2672623005: Record Autofill form events specially for nonsecure pages (Closed)
Patch Set: fix test added in rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_manager.cc
diff --git a/components/autofill/core/browser/autofill_manager.cc b/components/autofill/core/browser/autofill_manager.cc
index 87c8d54fafac90ade40c4a2c5c679f8442fe2279..ec67d0c32619883be8c59e65a3d1d9ed8d482886 100644
--- a/components/autofill/core/browser/autofill_manager.cc
+++ b/components/autofill/core/browser/autofill_manager.cc
@@ -534,7 +534,7 @@ void AutofillManager::OnTextFieldDidChange(const FormData& form,
}
bool AutofillManager::IsFormNonSecure(const FormData& form) const {
- return !client_->IsContextSecure(form.origin) ||
+ return !client_->IsContextSecure() ||
(form.action.is_valid() && form.action.SchemeIs("http"));
}
@@ -575,7 +575,6 @@ void AutofillManager::OnQueryFormFieldAutofill(int query_id,
std::vector<Suggestion> suggestions;
const bool is_context_secure = !IsFormNonSecure(form);
-
const bool is_http_warning_enabled =
security_state::IsHttpWarningInFormEnabled();
@@ -1474,6 +1473,8 @@ bool AutofillManager::RefreshDataModels() {
is_server_data_available);
credit_card_form_event_logger_->set_is_local_data_available(
is_local_data_available);
+ credit_card_form_event_logger_->set_is_context_secure(
+ client_->IsContextSecure());
}
{
bool is_server_data_available = false;
« no previous file with comments | « components/autofill/core/browser/autofill_client.h ('k') | components/autofill/core/browser/autofill_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698