Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Unified Diff: components/autofill/core/browser/autofill_manager.cc

Issue 2672623005: Record Autofill form events specially for nonsecure pages (Closed)
Patch Set: fix autofillassistant call site Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_manager.cc
diff --git a/components/autofill/core/browser/autofill_manager.cc b/components/autofill/core/browser/autofill_manager.cc
index 72cf42156b3eb55a299558fdbe890ff651ddb29b..45ada5a2f865b3c3abe2862ddba5e6a26295795a 100644
--- a/components/autofill/core/browser/autofill_manager.cc
+++ b/components/autofill/core/browser/autofill_manager.cc
@@ -564,10 +564,9 @@ void AutofillManager::OnQueryFormFieldAutofill(int query_id,
std::vector<Suggestion> suggestions;
const bool is_context_secure =
- !form_structure ||
- (client_->IsContextSecure(form_structure->source_url()) &&
- (!form_structure->target_url().is_valid() ||
- !form_structure->target_url().SchemeIs("http")));
+ !form_structure || (client_->IsContextSecure() &&
+ (!form_structure->target_url().is_valid() ||
+ !form_structure->target_url().SchemeIs("http")));
const bool is_http_warning_enabled =
security_state::IsHttpWarningInFormEnabled();
@@ -1466,6 +1465,8 @@ bool AutofillManager::RefreshDataModels() {
is_server_data_available);
credit_card_form_event_logger_->set_is_local_data_available(
is_local_data_available);
+ credit_card_form_event_logger_->set_is_context_secure(
+ client_->IsContextSecure());
}
{
bool is_server_data_available = false;

Powered by Google App Engine
This is Rietveld 408576698