tools/metrics/histograms/histograms.xml - Issue 2672623005: Record Autofill form events specially for nonsecure pages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 2672623005: Record Autofill form events specially for nonsecure pages (Closed)

Patch Set: fix test added in rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index fe56fac980ae5f2ee096ab3cf0372915639bea69..7ab89eb72291340fc21232de41b122b6d9f0580d 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -3364,7 +3364,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

the data after and then submitted, we would only emit one "Submitted

with server suggestion filled (once)"; - The submission segmentation

works by checking what kind of data was last filled for this type of form in

- the page load. So, if I user initially filled with local data and after that

+ the page load. So, if a user initially filled with local data and after that

filled with server, we will only emit "Submitted with server suggestion

filled (once)".

</details>

@@ -3383,7 +3383,27 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

the data after and then submitted, we would only emit one "Submitted

with server suggestion filled (once)"; - The submission segmentation

works by checking what kind of data was last filled for this type of form in

- the page load. So, if I user initially filled with local data and after that

+ the page load. So, if a user initially filled with local data and after that

+ filled with server, we will only emit "Submitted with server suggestion

+ filled (once)".

+ </details>

+</histogram>

+<histogram name="Autofill.FormEvents.CreditCard.OnNonsecurePage"

+ enum="AutofillFormEvent">

+ <owner>estark@chromium.org</owner>

+ <summary>

+ Autofill form events for credit card forms on nonsecure pages. These are

+ recorded when the user interacts with a form requesting a credit card.

+ </summary>

+ <details>

+ Important caveat about submission metrics: - Submission using autofill data

+ is determined by simply evaluating if there was a fill operation in this

+ page. So, if the user filled with local data, completed erased or modified

+ the data after and then submitted, we would only emit one "Submitted

+ with server suggestion filled (once)"; - The submission segmentation

+ works by checking what kind of data was last filled for this type of form in

+ the page load. So, if a user initially filled with local data and after that

filled with server, we will only emit "Submitted with server suggestion

filled (once)".

</details>

« no previous file with comments | « ios/chrome/browser/ui/autofill/autofill_client_ios.mm ('k') | no next file » | no next file with comments »