Fetch a new GAIA picture every time chrome://settings/manageProfile comes up.

chrome/browser/resources/options/browser_options.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   var OptionsPage = options.OptionsPage;
   var ArrayDataModel = cr.ui.ArrayDataModel;
   var RepeatingButton = cr.ui.RepeatingButton;
   var HotwordSearchSettingIndicator = options.HotwordSearchSettingIndicator;
 
@@ skipping 230 matching lines @@
         $('profiles-create').onclick = function(event) {
           ManageProfileOverlay.showCreateDialog();
         };
         if (OptionsPage.isSettingsApp()) {
           $('profiles-app-list-switch').onclick = function(event) {
             var selectedProfile = self.getSelectedProfileItem_();
             chrome.send('switchAppListProfile', [selectedProfile.filePath]);
           };
         }
         $('profiles-manage').onclick = function(event) {
+          chrome.send('refreshGAIAPicture');

[Evan Stade, 2014/05/07 22:38:55]

why isn't this in ManageProfileOverlay.showManageDialog?

[noms (inactive), 2014/05/08 01:02:29]

showManageDialog is also called by setProfilesInfo_, which is called when the
ProfileInfoCache updates (i.e. after the gaia picture has been refreshed). So
moving it to there leads to an infinite loop. 

On 2014/05/07 22:38:55, Evan Stade wrote:

[Evan Stade, 2014/05/08 01:09:57]

seems like the info cache shouldn't be updated if the gaia picture hasn't
actually changed.

[noms (inactive), 2014/05/08 15:29:06]

We would have to do a pixel-by-pixel check when we re-download it, which we
currently don't. Basically, the GaiaInfoUpdateService just re-downloads the file
from a web service (which doesn't tell you when the file has been updated, to my
knowledge), and the ProfileInfoCache replaces the existing one with the new one.


On 2014/05/08 01:09:57, Evan Stade wrote:

[Evan Stade, 2014/05/14 03:09:55]

Are you suggesting that checking the pixels is going to be too slow? It's just a
memcmp. Isn't sending the pixels over various wires to the renderer, repainting
the screen, etc., even slower?
I don't see a showManageDialog call in setProfilesInfo_. In any case, if we want
to get a new gaia picture when the dialog is shown, I think this code is too
fragile.

[noms (inactive), 2014/05/20 20:08:57]

setProfilesInfo_ calls ManageProfileOverlay.showManageDialog() if the dialog is
already showing:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res...

The people get api does not have a "last updated" field for the profile photo,
so if we want to make sure we are using the user's latest photo, we need to
always re-fetch it when editing the profile, i.e. showManageDialog is called. 

I will add the "if it's the same image don't update the info cache" code, and
rename the chrome signal to maybeRefreshGaiaPicture. Does that sound ok?


On 2014/05/14 03:09:55, Evan Stade wrote:

           ManageProfileOverlay.showManageDialog();
         };
         $('profiles-delete').onclick = function(event) {
           var selectedProfile = self.getSelectedProfileItem_();
           if (selectedProfile)
             ManageProfileOverlay.showDeleteDialog(selectedProfile);
         };
         if (loadTimeData.getBoolean('profileIsManaged')) {
           $('profiles-create').disabled = true;
           $('profiles-delete').disabled = true;
@@ skipping 1554 matching lines @@
     BrowserOptions.getLoggedInUsername = function() {
       return BrowserOptions.getInstance().username_;
     };
   }
 
   // Export
   return {
     BrowserOptions: BrowserOptions
   };
 });