Begin hooking up Fasta to analyzer parser tests.

Begin hooking up Fasta to analyzer parser tests.

R=ahe@google.com

Committed: https://github.com/dart-lang/sdk/commit/62604294a224be9616dd265981fb3e7bbb130911

[Paul Berry, 2017-02-06 21:43:56]

paulberry@google.com changed reviewers:
+ ahe@google.com

[ahe, 2017-02-07 09:47:16]

lgtm

https://codereview.chromium.org/2672403004/diff/1/pkg/analyzer/test/generated...
File pkg/analyzer/test/generated/parser_test_fasta.dart (right):

https://codereview.chromium.org/2672403004/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/parser_test_fasta.dart:32: class BuilderProxy
implements Builder {
Do you need to use @proxy?

https://codereview.chromium.org/2672403004/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/parser_test_fasta.dart:71:
.test_assignableExpression_arguments_normal_chain_typeArgumentComments();
Long line.

https://codereview.chromium.org/2672403004/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart (right):

https://codereview.chromium.org/2672403004/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart:453: // element?
FYI: I have a more complete implementation of this in kernel/body_builder.dart.
I hope to be able to share this by generalizing the implementation in
BodyBuilder.

https://codereview.chromium.org/2672403004/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/loader.dart (right):

https://codereview.chromium.org/2672403004/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/loader.dart:135: /// Builds all the method bodies
found in a given [library].
"a given" -> "the given"?

[Paul Berry, 2017-02-07 13:45:13]

https://codereview.chromium.org/2672403004/diff/1/pkg/analyzer/test/generated...
File pkg/analyzer/test/generated/parser_test_fasta.dart (right):

https://codereview.chromium.org/2672403004/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/parser_test_fasta.dart:32: class BuilderProxy
implements Builder {
On 2017/02/07 09:47:16, ahe wrote:
> Do you need to use @proxy?

No.  "@proxy" is appropriate when the class's implementation of noSuchMethod is
able to handle the method invocation.  In this case, we are choosing not to
implement some members of the Builder class because we know that at runtime they
won't be called.

Adding "@proxy" would actually be counterproductive because it would suppress
"no such method" warnings in cases where the target of the method invocation is
known to be a BuilderProxy rather than simply a Builder; should a case like that
arise, we would need to implement the corresponding method, so the warning would
be useful.

https://codereview.chromium.org/2672403004/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/parser_test_fasta.dart:71:
.test_assignableExpression_arguments_normal_chain_typeArgumentComments();
On 2017/02/07 09:47:16, ahe wrote:
> Long line.

Acknowledged.

https://codereview.chromium.org/2672403004/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart (right):

https://codereview.chromium.org/2672403004/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart:453: // element?
On 2017/02/07 09:47:16, ahe wrote:
> FYI: I have a more complete implementation of this in
kernel/body_builder.dart.
> I hope to be able to share this by generalizing the implementation in
> BodyBuilder.

Cool, glad to hear it.

https://codereview.chromium.org/2672403004/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/loader.dart (right):

https://codereview.chromium.org/2672403004/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/loader.dart:135: /// Builds all the method bodies
found in a given [library].
On 2017/02/07 09:47:16, ahe wrote:
> "a given" -> "the given"?

Done.

[Paul Berry, 2017-02-07 13:46:04]

Description was changed from

==========
Begin hooking up Fasta to analyzer parser tests.
==========

to

==========
Begin hooking up Fasta to analyzer parser tests.

R=ahe@google.com

Committed:
https://github.com/dart-lang/sdk/commit/62604294a224be9616dd265981fb3e7bbb130911
==========

[Paul Berry, 2017-02-07 13:46:06]

Committed patchset #1 (id:1) manually as
62604294a224be9616dd265981fb3e7bbb130911 (presubmit successful).