Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 26723003: Linux: switch to using pkg-config for unbundled ICU (Closed)

Created:
7 years, 2 months ago by Paweł Hajdan Jr.
Modified:
7 years, 2 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, jshin+watch_chromium.org
Visibility:
Public.

Description

Linux: switch to using pkg-config for unbundled ICU This was recommended by upstream ICU developer in https://ssl.icu-project.org/trac/ticket/6102 and should avoid issues with contaminated flags in icu-config. BUG=none R=thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=228979

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -14 lines) Patch
M build/linux/unbundle/icu.gyp View 2 chunks +38 lines, -14 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paweł Hajdan Jr.
7 years, 2 months ago (2013-10-16 01:37:05 UTC) #1
Lei Zhang
lgtm
7 years, 2 months ago (2013-10-16 20:30:15 UTC) #2
Paweł Hajdan Jr.
7 years, 2 months ago (2013-10-16 21:32:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r228979 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698