Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: tools/testing/dart/test_configurations.dart

Issue 2672243005: test.dart: Find cdb.exe automatically from depot_tools when running Windows tests (Closed)
Patch Set: add comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/testing/dart/test_runner.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_configurations.dart
diff --git a/tools/testing/dart/test_configurations.dart b/tools/testing/dart/test_configurations.dart
index 9418bd7d083c2ad0593f82aa16c933cef96cc967..8944af89200a712423cae6161fd80bc9da63a0b4 100644
--- a/tools/testing/dart/test_configurations.dart
+++ b/tools/testing/dart/test_configurations.dart
@@ -5,6 +5,7 @@
library test_configurations;
import "dart:async";
+import 'dart:convert';
import 'dart:io';
import "dart:math" as math;
@@ -54,6 +55,9 @@ final TEST_SUITE_DIRECTORIES = [
new Path('utils/tests/peg'),
];
+// This file is created by gclient runhooks.
+final VS_TOOLCHAIN_FILE = new Path("build/win_toolchain.json");
+
Future testConfigurations(List<Map> configurations) async {
var startTime = new DateTime.now();
// Extract global options from first configuration.
@@ -294,6 +298,13 @@ Future testConfigurations(List<Map> configurations) async {
await Future.wait(serverFutures);
}
+ if (Platform.isWindows) {
+ // When running tests on Windows, use cdb from depot_tools to dump
+ // stack traces of tests timing out.
Bill Hesse 2017/03/01 13:45:56 It would be good to put this in a try block, so it
Florian Schneider 2017/03/02 22:56:08 I'll add one here.
+ var text = await new File(VS_TOOLCHAIN_FILE.toNativePath()).readAsString();
+ firstConf['win_sdk_path'] = JSON.decode(text)['win_sdk'];
+ }
+
// [firstConf] is needed here, since the ProcessQueue needs to know the
// settings of 'noBatch' and 'local_ip'
new ProcessQueue(
« no previous file with comments | « no previous file | tools/testing/dart/test_runner.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698