Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: tools/testing/dart/test_configurations.dart

Issue 2672243005: test.dart: Find cdb.exe automatically from depot_tools when running Windows tests (Closed)
Patch Set: address comment Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/testing/dart/test_runner.dart » ('j') | tools/testing/dart/test_runner.dart » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library test_configurations; 5 library test_configurations;
6 6
7 import "dart:async"; 7 import "dart:async";
8 import 'dart:convert';
8 import 'dart:io'; 9 import 'dart:io';
9 import "dart:math" as math; 10 import "dart:math" as math;
10 11
11 import 'android.dart'; 12 import 'android.dart';
12 import "browser_controller.dart"; 13 import "browser_controller.dart";
13 import "co19_test_config.dart"; 14 import "co19_test_config.dart";
14 import "http_server.dart"; 15 import "http_server.dart";
15 import "path.dart"; 16 import "path.dart";
16 import "test_progress.dart"; 17 import "test_progress.dart";
17 import "test_runner.dart"; 18 import "test_runner.dart";
(...skipping 29 matching lines...) Expand all
47 new Path('tests/language'), 48 new Path('tests/language'),
48 new Path('tests/language_strong'), 49 new Path('tests/language_strong'),
49 new Path('tests/lib'), 50 new Path('tests/lib'),
50 new Path('tests/lib_strong'), 51 new Path('tests/lib_strong'),
51 new Path('tests/standalone'), 52 new Path('tests/standalone'),
52 new Path('tests/utils'), 53 new Path('tests/utils'),
53 new Path('utils/tests/css'), 54 new Path('utils/tests/css'),
54 new Path('utils/tests/peg'), 55 new Path('utils/tests/peg'),
55 ]; 56 ];
56 57
58 final VS_TOOLCHAIN_FILE = new Path("build/win_toolchain.json");
kustermann 2017/02/07 15:52:53 Maybe add a comment here where the json file is co
Florian Schneider 2017/02/14 11:12:46 Done.
59
57 Future testConfigurations(List<Map> configurations) async { 60 Future testConfigurations(List<Map> configurations) async {
58 var startTime = new DateTime.now(); 61 var startTime = new DateTime.now();
59 // Extract global options from first configuration. 62 // Extract global options from first configuration.
60 var firstConf = configurations[0]; 63 var firstConf = configurations[0];
61 var maxProcesses = firstConf['tasks']; 64 var maxProcesses = firstConf['tasks'];
62 var progressIndicator = firstConf['progress']; 65 var progressIndicator = firstConf['progress'];
63 BuildbotProgressIndicator.stepName = firstConf['step_name']; 66 BuildbotProgressIndicator.stepName = firstConf['step_name'];
64 var verbose = firstConf['verbose']; 67 var verbose = firstConf['verbose'];
65 var printTiming = firstConf['time']; 68 var printTiming = firstConf['time'];
66 var listTests = firstConf['list']; 69 var listTests = firstConf['list'];
(...skipping 220 matching lines...) Expand 10 before | Expand all | Expand 10 after
287 }); 290 });
288 if (needsAdbDevicePool) { 291 if (needsAdbDevicePool) {
289 adbDevicePool = await AdbDevicePool.create(); 292 adbDevicePool = await AdbDevicePool.create();
290 } 293 }
291 294
292 // Start all the HTTP servers required before starting the process queue. 295 // Start all the HTTP servers required before starting the process queue.
293 if (!serverFutures.isEmpty) { 296 if (!serverFutures.isEmpty) {
294 await Future.wait(serverFutures); 297 await Future.wait(serverFutures);
295 } 298 }
296 299
300 if (Platform.isWindows) {
301 // When running tests on Windows, use cdb from depot_tools to dump
302 // stack traces of tests timing out.
303 var text = await new File(VS_TOOLCHAIN_FILE.toNativePath()).readAsString();
304 firstConf['win_sdk_path'] = JSON.decode(text)['win_sdk'];
305 }
306
297 // [firstConf] is needed here, since the ProcessQueue needs to know the 307 // [firstConf] is needed here, since the ProcessQueue needs to know the
298 // settings of 'noBatch' and 'local_ip' 308 // settings of 'noBatch' and 'local_ip'
299 new ProcessQueue( 309 new ProcessQueue(
300 firstConf, 310 firstConf,
301 maxProcesses, 311 maxProcesses,
302 maxBrowserProcesses, 312 maxBrowserProcesses,
303 startTime, 313 startTime,
304 testSuites, 314 testSuites,
305 eventListener, 315 eventListener,
306 allTestsFinished, 316 allTestsFinished,
307 verbose, 317 verbose,
308 recordingPath, 318 recordingPath,
309 recordingOutputPath, 319 recordingOutputPath,
310 adbDevicePool); 320 adbDevicePool);
311 } 321 }
OLDNEW
« no previous file with comments | « no previous file | tools/testing/dart/test_runner.dart » ('j') | tools/testing/dart/test_runner.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698