[inspector] introduced v8::debug::EntriesPreview for inspector

src/runtime/runtime-collections.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/runtime/runtime-utils.h"
 
 #include "src/arguments.h"
 #include "src/conversions-inl.h"
 #include "src/factory.h"
 
@@ skipping 208 matching lines @@
   HandleScope scope(isolate);
   DCHECK_EQ(1, args.length());
   CONVERT_ARG_HANDLE_CHECKED(JSMapIterator, holder, 0);
   Handle<FixedArray> details = isolate->factory()->NewFixedArray(4);
   details->set(0, isolate->heap()->ToBoolean(holder->HasMore()));
   details->set(1, holder->index());
   details->set(2, holder->kind());
   return *isolate->factory()->NewJSArrayWithElements(details);
 }
 
-
-RUNTIME_FUNCTION(Runtime_GetWeakMapEntries) {
-  HandleScope scope(isolate);
-  DCHECK_EQ(2, args.length());
-  CONVERT_ARG_HANDLE_CHECKED(JSWeakCollection, holder, 0);
-  CONVERT_NUMBER_CHECKED(int, max_entries, Int32, args[1]);
-  CHECK(max_entries >= 0);
-
+Handle<JSArray> Runtime::GetWeakMapEntries(Isolate* isolate,
+                                           Handle<JSWeakCollection> holder,
+                                           int max_entries) {
   Handle<ObjectHashTable> table(ObjectHashTable::cast(holder->table()));
   if (max_entries == 0 || max_entries > table->NumberOfElements()) {
     max_entries = table->NumberOfElements();
   }
   Handle<FixedArray> entries =
       isolate->factory()->NewFixedArray(max_entries * 2);
   // Allocation can cause GC can delete weak elements. Reload.
   if (max_entries > table->NumberOfElements()) {
     max_entries = table->NumberOfElements();
   }
 
   {
     DisallowHeapAllocation no_gc;
     int count = 0;
     for (int i = 0; count / 2 < max_entries && i < table->Capacity(); i++) {
       Handle<Object> key(table->KeyAt(i), isolate);
       if (table->IsKey(isolate, *key)) {
         entries->set(count++, *key);
         Object* value = table->Lookup(key);
         entries->set(count++, value);
       }
     }
     DCHECK_EQ(max_entries * 2, count);
   }
-  return *isolate->factory()->NewJSArrayWithElements(entries);
+  return isolate->factory()->NewJSArrayWithElements(entries);
+}
+
+RUNTIME_FUNCTION(Runtime_GetWeakMapEntries) {

[Yang, 2017/02/06 10:41:30]

Can we move that to JSWeakMap?

[jgruber, 2017/02/06 12:40:39]

+1

[kozy, 2017/02/06 18:39:26]

Done.

+  HandleScope scope(isolate);
+  DCHECK_EQ(2, args.length());
+  CONVERT_ARG_HANDLE_CHECKED(JSWeakCollection, holder, 0);
+  CONVERT_NUMBER_CHECKED(int, max_entries, Int32, args[1]);
+  CHECK(max_entries >= 0);
+  return *Runtime::GetWeakMapEntries(isolate, holder, max_entries);
 }
 
 
 RUNTIME_FUNCTION(Runtime_MapIteratorNext) {
   SealHandleScope shs(isolate);
   DCHECK_EQ(2, args.length());
   CONVERT_ARG_CHECKED(JSMapIterator, holder, 0);
   CONVERT_ARG_CHECKED(JSArray, value_array, 1);
   return holder->Next(value_array);
 }
@@ skipping 62 matching lines @@
   CHECK(key->IsJSReceiver() || key->IsSymbol());
   CONVERT_ARG_HANDLE_CHECKED(Object, value, 2);
   CONVERT_SMI_ARG_CHECKED(hash, 3)
   Handle<ObjectHashTable> table(
       ObjectHashTable::cast(weak_collection->table()));
   CHECK(table->IsKey(isolate, *key));
   JSWeakCollection::Set(weak_collection, key, value, hash);
   return *weak_collection;
 }
 
-
-RUNTIME_FUNCTION(Runtime_GetWeakSetValues) {
-  HandleScope scope(isolate);
-  DCHECK_EQ(2, args.length());
-  CONVERT_ARG_HANDLE_CHECKED(JSWeakCollection, holder, 0);
-  CONVERT_NUMBER_CHECKED(int, max_values, Int32, args[1]);
-  CHECK(max_values >= 0);
-
+Handle<JSArray> Runtime::GetWeakSetEntries(Isolate* isolate,

[Yang, 2017/02/06 10:41:30]

Can we move that to JSWeakSet?

[kozy, 2017/02/06 18:39:26]

Done.

+                                           Handle<JSWeakCollection> holder,
+                                           int max_values) {
   Handle<ObjectHashTable> table(ObjectHashTable::cast(holder->table()));
   if (max_values == 0 || max_values > table->NumberOfElements()) {
     max_values = table->NumberOfElements();
   }
   Handle<FixedArray> values = isolate->factory()->NewFixedArray(max_values);
   // Recompute max_values because GC could have removed elements from the table.
   if (max_values > table->NumberOfElements()) {
     max_values = table->NumberOfElements();
   }
   {
     DisallowHeapAllocation no_gc;
     int count = 0;
     for (int i = 0; count < max_values && i < table->Capacity(); i++) {
       Object* key = table->KeyAt(i);
       if (table->IsKey(isolate, key)) values->set(count++, key);
     }
     DCHECK_EQ(max_values, count);
   }
-  return *isolate->factory()->NewJSArrayWithElements(values);
+  return isolate->factory()->NewJSArrayWithElements(values);
+}
+
+RUNTIME_FUNCTION(Runtime_GetWeakSetValues) {
+  HandleScope scope(isolate);
+  DCHECK_EQ(2, args.length());
+  CONVERT_ARG_HANDLE_CHECKED(JSWeakCollection, holder, 0);
+  CONVERT_NUMBER_CHECKED(int, max_values, Int32, args[1]);
+  CHECK(max_values >= 0);
+  return *Runtime::GetWeakSetEntries(isolate, holder, max_values);
 }
 }  // namespace internal
 }  // namespace v8