[DevTools] Search in Elements tab is not working for newly added elements

third_party/WebKit/Source/devtools/front_end/ui/SearchableView.js

 /*
  * Copyright (C) 2006, 2007, 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2007 Matt Lilek (pewtermoose@gmail.com).
  * Copyright (C) 2009 Joseph Pecoraro
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
@@ skipping 334 matching lines @@
     if (!this._searchInputElement.hasFocus()) {
       var selection = this._searchInputElement.getComponentSelection();
       if (selection.rangeCount)
         queryCandidate = selection.toString().replace(/\r?\n.*/, '');
     }
 
     this._toggleSearchBar(true);
     this._updateReplaceVisibility();
     if (queryCandidate)
       this._searchInputElement.value = queryCandidate;
+    this._searchProvider.searchCanceled();

[Oleksii Kadurin, 2017/02/07 20:20:24]

Reset search by explicit invocation of .searchCanceled()

[pfeldman, 2017/02/07 23:19:36]

This might come unexpected to the provider, why do we need it here?

[Oleksii Kadurin, 2017/02/07 23:57:18]

It was the part of performSearch function (in the ElementsPanel.js file 467). I
moved that call outside the function. And call it every time the reset is
needed. It is also initialization/reset for this._currentSearchResultIndex when
a user hit Ctrl + F.

[pfeldman, 2017/02/08 01:52:41]

Right, but you are changing this contract for all the SearchableViews now, which
might be unexpected to respective providers:

https://cs.chromium.org/search/?q=UI.SearchableView%5C(+package:%5Echromium$&...

Your change should only touch ElementsPanel it seems.

[Oleksii Kadurin, 2017/02/08 18:49:14]

I've got it now. Thanks!

     this._performSearch(false, false);
     this._searchInputElement.focus();
     this._searchInputElement.select();
     this._searchIsVisible = true;
   }
 
   _updateReplaceVisibility() {
     this._replaceElement.classList.toggle('hidden', !this._replaceable);
     if (!this._replaceable) {
       this._replaceCheckboxElement.checked = false;
       this._updateSecondRowVisibility();
     }
   }
 
   /**
    * @param {!Event} event
    */
   _onSearchKeyDown(event) {
     if (isEscKey(event)) {
       this.closeSearch();
       event.consume(true);
       return;
     }
     if (!isEnterKey(event))
       return;
 
     if (!this._currentQuery)
-      this._performSearch(true, true, event.shiftKey);
+      this._clearSearch();
     else
-      this._jumpToNextSearchResult(event.shiftKey);
+      this._performSearch(false, true, event.shiftKey);
   }
 
   /**
    * @param {!Event} event
    */
   _onReplaceKeyDown(event) {
     if (isEnterKey(event))
       this._replace();
   }
 
   /**
    * @param {boolean=} isBackwardSearch
    */
   _jumpToNextSearchResult(isBackwardSearch) {
     if (!this._currentQuery || !this._searchNavigationPrevElement.classList.contains('enabled'))
       return;
 
     if (isBackwardSearch)
       this._searchProvider.jumpToPreviousSearchResult();
     else
       this._searchProvider.jumpToNextSearchResult();
   }
 
   _onNextButtonSearch(event) {
     if (!this._searchNavigationNextElement.classList.contains('enabled'))
       return;
-    this._jumpToNextSearchResult();
+    this._performSearch(false, true);
     this._searchInputElement.focus();
   }
 
   _onPrevButtonSearch(event) {
     if (!this._searchNavigationPrevElement.classList.contains('enabled'))
       return;
-    this._jumpToNextSearchResult(true);
+    this._performSearch(false, true, true);
     this._searchInputElement.focus();
   }
 
   _onFindClick(event) {
     if (!this._currentQuery)
       this._performSearch(true, true);
     else
       this._jumpToNextSearchResult();
     this._searchInputElement.focus();
   }
@@ skipping 80 matching lines @@
     if (this._valueChangedTimeoutId)
       clearTimeout(this._valueChangedTimeoutId);
     var timeout = this._searchInputElement.value.length < 3 ? 200 : 0;
     this._valueChangedTimeoutId = setTimeout(this._onValueChanged.bind(this), timeout);
   }
 
   _onValueChanged() {
     if (!this._searchIsVisible)
       return;
     delete this._valueChangedTimeoutId;
+    this._searchProvider.searchCanceled();

[Oleksii Kadurin, 2017/02/07 20:20:24]

Reset search by explicit invocation of .searchCanceled()

[pfeldman, 2017/02/07 23:19:36]

That seems fine.

     this._performSearch(false, true);
   }
 };
 
 UI.SearchableView._lastUniqueId = 0;
 
 UI.SearchableView._symbol = Symbol('searchableView');
 
 
 /**
@@ skipping 82 matching lines @@
       // Silent catch.
     }
 
     // Otherwise just do a plain text search.
     if (!regex)
       regex = createPlainTextSearchRegex(query, modifiers);
 
     return regex;
   }
 };