[DevTools] Search in Elements tab is not working for newly added elements

third_party/WebKit/Source/devtools/front_end/ui/SearchableView.js

 /*
  * Copyright (C) 2006, 2007, 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2007 Matt Lilek (pewtermoose@gmail.com).
  * Copyright (C) 2009 Joseph Pecoraro
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
@@ skipping 334 matching lines @@
     if (!this._searchInputElement.hasFocus()) {
       var selection = this._searchInputElement.getComponentSelection();
       if (selection.rangeCount)
         queryCandidate = selection.toString().replace(/\r?\n.*/, '');
     }
 
     this._toggleSearchBar(true);
     this._updateReplaceVisibility();
     if (queryCandidate)
       this._searchInputElement.value = queryCandidate;
-    this._performSearch(false, false);
+    this._performSearch(false, false, false, true);
     this._searchInputElement.focus();
     this._searchInputElement.select();
     this._searchIsVisible = true;
   }
 
   _updateReplaceVisibility() {
     this._replaceElement.classList.toggle('hidden', !this._replaceable);
     if (!this._replaceable) {
       this._replaceCheckboxElement.checked = false;
       this._updateSecondRowVisibility();
     }
   }
 
   /**
    * @param {!Event} event
    */
   _onSearchKeyDown(event) {
     if (isEscKey(event)) {
       this.closeSearch();
       event.consume(true);
       return;
     }
     if (!isEnterKey(event))
       return;
 
     if (!this._currentQuery)
-      this._performSearch(true, true, event.shiftKey);
+      this._clearSearch();
     else
-      this._jumpToNextSearchResult(event.shiftKey);
+      this._performSearch(false, true, event.shiftKey);
   }
 
   /**
    * @param {!Event} event
    */
   _onReplaceKeyDown(event) {
     if (isEnterKey(event))
       this._replace();
   }
 
   /**
    * @param {boolean=} isBackwardSearch
    */
   _jumpToNextSearchResult(isBackwardSearch) {
     if (!this._currentQuery || !this._searchNavigationPrevElement.classList.contains('enabled'))
       return;
 
     if (isBackwardSearch)
       this._searchProvider.jumpToPreviousSearchResult();
     else
       this._searchProvider.jumpToNextSearchResult();
   }
 
   _onNextButtonSearch(event) {
     if (!this._searchNavigationNextElement.classList.contains('enabled'))
       return;
-    this._jumpToNextSearchResult();
+    this._performSearch(false, true);
     this._searchInputElement.focus();
   }
 
   _onPrevButtonSearch(event) {
     if (!this._searchNavigationPrevElement.classList.contains('enabled'))
       return;
-    this._jumpToNextSearchResult(true);
+    this._performSearch(false, true, true);
     this._searchInputElement.focus();
   }
 
   _onFindClick(event) {
     if (!this._currentQuery)
       this._performSearch(true, true);
     else
       this._jumpToNextSearchResult();
     this._searchInputElement.focus();
   }
@@ skipping 12 matching lines @@
       delete this._searchProvider.currentQuery;
       this._searchProvider.searchCanceled();
     }
     this._updateSearchMatchesCountAndCurrentMatchIndex(0, -1);
   }
 
   /**
    * @param {boolean} forceSearch
    * @param {boolean} shouldJump
    * @param {boolean=} jumpBackwards
+   * @param {boolean=} reset
    */
-  _performSearch(forceSearch, shouldJump, jumpBackwards) {
+  _performSearch(forceSearch, shouldJump, jumpBackwards, reset) {
     var query = this._searchInputElement.value;
     if (!query || (!forceSearch && query.length < this._minimalSearchQuerySize && !this._currentQuery)) {
       this._clearSearch();
       return;
     }
 
     this._currentQuery = query;
     this._searchProvider.currentQuery = query;
 
     var searchConfig = this._currentSearchConfig();
-    this._searchProvider.performSearch(searchConfig, shouldJump, jumpBackwards);
+    this._searchProvider.performSearch(searchConfig, shouldJump, jumpBackwards, reset);
   }
 
   /**
    * @return {!UI.SearchableView.SearchConfig}
    */
   _currentSearchConfig() {
     var query = this._searchInputElement.value;
     var caseSensitive = this._caseSensitiveButton ? this._caseSensitiveButton.toggled() : false;
     var isRegex = this._regexButton ? this._regexButton.toggled() : false;
     return new UI.SearchableView.SearchConfig(query, caseSensitive, isRegex);
@@ skipping 35 matching lines @@
     if (this._valueChangedTimeoutId)
       clearTimeout(this._valueChangedTimeoutId);
     var timeout = this._searchInputElement.value.length < 3 ? 200 : 0;
     this._valueChangedTimeoutId = setTimeout(this._onValueChanged.bind(this), timeout);
   }
 
   _onValueChanged() {
     if (!this._searchIsVisible)
       return;
     delete this._valueChangedTimeoutId;
-    this._performSearch(false, true);
+    this._performSearch(false, true, false, true);
   }
 };
 
 UI.SearchableView._lastUniqueId = 0;
 
 UI.SearchableView._symbol = Symbol('searchableView');
 
 
 /**
  * @interface
  */
 UI.Searchable = function() {};
 
 UI.Searchable.prototype = {
   searchCanceled() {},
 
   /**
    * @param {!UI.SearchableView.SearchConfig} searchConfig
    * @param {boolean} shouldJump
    * @param {boolean=} jumpBackwards
+   * @param {boolean=} reset
    */
-  performSearch(searchConfig, shouldJump, jumpBackwards) {},
+  performSearch(searchConfig, shouldJump, jumpBackwards, reset) {},

[pfeldman, 2017/02/06 19:24:53]

This makes our contract a bit more redundant - I would say that when you need to
reset, you could just call searchCanceled.

[Oleksii Kadurin, 2017/02/07 20:20:24]

I removed the "reset" parameter. And now I'm using
this._currentSearchResultIndex as a reset marker. That value is "undefined" just
after calling of .searchCanceled(). 

 
   jumpToNextSearchResult() {},
 
   jumpToPreviousSearchResult() {},
 
   /**
    * @return {boolean}
    */
   supportsCaseSensitiveSearch() {},
 
@@ skipping 59 matching lines @@
       // Silent catch.
     }
 
     // Otherwise just do a plain text search.
     if (!regex)
       regex = createPlainTextSearchRegex(query, modifiers);
 
     return regex;
   }
 };