Implement SuperPropertySet and SuperNoSuchMethod.

Implement SuperPropertySet and SuperNoSuchMethod.

BUG=https://github.com/dart-lang/sdk/issues/27394
R=sra@google.com

Committed: https://github.com/dart-lang/sdk/commit/f5cc947dd7d159fb409f80d477966edae6bf8629

[Emily Fortuna, 2017-02-03 19:36:10]

Patchset #1 (id:1) has been deleted

[Emily Fortuna, 2017-02-03 19:37:58]

efortuna@google.com changed reviewers:
+ sra@google.com

[Emily Fortuna, 2017-02-03 19:37:58]

Of note: dart2js_native/super_property_test is still failing. However, it looks
like it's a problem with the native-ness and not the super-property get/set.
(getInterceptor returns null and test(things[2]); and test(things[3]); both
pass. Let me know if I should take another look and this interacts with native
in a way I wasn't expecting.

[sra1, 2017-02-03 21:07:42]

lgtm

https://codereview.chromium.org/2672063003/diff/40001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/builder_kernel.dart (right):

https://codereview.chromium.org/2672063003/diff/40001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder_kernel.dart:2649: ir.Procedure
_findNoSuchMethodInClass(ir.Class cls) {
Can closedWorld.locateSingleElement be used to do this lookup?

https://codereview.chromium.org/2672063003/diff/40001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder_kernel.dart:2694:
backend.constantSystem.createString(new DartString.literal(publicName));
Check that we generate the same code under --minify.

[Emily Fortuna, 2017-02-03 21:53:06]

https://codereview.chromium.org/2672063003/diff/40001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/builder_kernel.dart (right):

https://codereview.chromium.org/2672063003/diff/40001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder_kernel.dart:2649: ir.Procedure
_findNoSuchMethodInClass(ir.Class cls) {
On 2017/02/03 21:07:41, sra1 wrote:
> Can closedWorld.locateSingleElement be used to do this lookup?

Per offline discussion we decided to keep this since we will be writing this
code eventually anyway. Added a TODO to pull this code out if we find ourselves
writing it often.

https://codereview.chromium.org/2672063003/diff/40001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder_kernel.dart:2694:
backend.constantSystem.createString(new DartString.literal(publicName));
On 2017/02/03 21:07:41, sra1 wrote:
> Check that we generate the same code under --minify.

looks good!

[Emily Fortuna, 2017-02-03 22:17:59]

Description was changed from

==========
Implement SuperPropertySet and SuperNoSuchMethod.

BUG=https://github.com/dart-lang/sdk/issues/27394
==========

to

==========
Implement SuperPropertySet and SuperNoSuchMethod.

BUG=https://github.com/dart-lang/sdk/issues/27394
R=sra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/f5cc947dd7d159fb409f80d477966edae6bf8629
==========

[Emily Fortuna, 2017-02-03 22:18:00]

Committed patchset #3 (id:60001) manually as
f5cc947dd7d159fb409f80d477966edae6bf8629 (presubmit successful).