Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp

Issue 2672053003: Pass is_module flag when we V8ScriptRunner::compileModule (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp b/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
index f3d1ce21fe6cd0db8a4aa26cdd4797fd99268a77..5391482d81548700912e7efb8ea3a13cb71fd54c 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
@@ -500,7 +500,15 @@ v8::MaybeLocal<v8::Module> V8ScriptRunner::compileModule(
TRACE_EVENT1("v8", "v8.compileModule", "fileName", fileName.utf8());
// TODO(adamk): Add Inspector integration?
// TODO(adamk): Pass more info into ScriptOrigin.
- v8::ScriptOrigin origin(v8String(isolate, fileName));
+ v8::ScriptOrigin origin(v8String(isolate, fileName),
+ v8::Integer::New(isolate, 0), // line_offset
+ v8::Integer::New(isolate, 0), // col_offset
+ v8Boolean(true, isolate), // accessControlStatus
+ v8::Local<v8::Integer>(), // script id
+ v8String(isolate, ""), // source_map_url
+ v8Boolean(false, isolate), // accessControlStatus
+ v8Boolean(false, isolate), // is_wasm
+ v8Boolean(true, isolate)); // is_module
v8::ScriptCompiler::Source scriptSource(v8String(isolate, source), origin);
return v8::ScriptCompiler::CompileModule(isolate, &scriptSource);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698