Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: chromeos/system/version_loader.h

Issue 2672023003: Use TaskScheduler instead of blocking pool in version_handler_chromeos.cc. (Closed)
Patch Set: may block comment Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/version_handler_chromeos.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/system/version_loader.h
diff --git a/chromeos/system/version_loader.h b/chromeos/system/version_loader.h
index de6d2d73dedddce66cf34cd288a348f6286125dc..db1b80efdf58cd42bb8124189feb7f3f700d859b 100644
--- a/chromeos/system/version_loader.h
+++ b/chromeos/system/version_loader.h
@@ -21,15 +21,15 @@ enum VersionFormat {
// Gets the version.
// If |full_version| is true version string with extra info is extracted,
// otherwise it's in short format x.x.xx.x.
-// Must be run on a blocking thread pool.
+// May block.
CHROMEOS_EXPORT std::string GetVersion(VersionFormat format);
// Gets the ARC version.
-// Must be run on a blocking thread pool.
+// May block.
CHROMEOS_EXPORT std::string GetARCVersion();
// Gets the firmware info.
-// Must be run on a blocking thread pool.
+// May block.
CHROMEOS_EXPORT std::string GetFirmware();
// Extracts the firmware from the file.
« no previous file with comments | « chrome/browser/ui/webui/version_handler_chromeos.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698