Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: ios/chrome/browser/ui/browser_view_controller.mm

Issue 2672023002: [ios] Prevent multiple page security popups in voice over mode. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/browser_view_controller.mm
diff --git a/ios/chrome/browser/ui/browser_view_controller.mm b/ios/chrome/browser/ui/browser_view_controller.mm
index f6623048705ccd76ded971a33c1cfbb103683fdb..69a19946c021b0e7b56c63efba094c34d0791b9e 100644
--- a/ios/chrome/browser/ui/browser_view_controller.mm
+++ b/ios/chrome/browser/ui/browser_view_controller.mm
@@ -3417,6 +3417,11 @@ class BrowserBookmarkModelBridge : public bookmarks::BookmarkModelObserver {
if ([self isTabNativePage:tab])
return;
+ // Don't show the bubble twice (this can happen when tapping very quickly in
+ // accessibility mode
rohitrao (ping after 24h) 2017/02/06 14:02:13 Missing close paren. Why is this only triggered b
justincohen 2017/02/06 15:49:54 Done.
+ if (_pageInfoController)
+ return;
+
base::RecordAction(UserMetricsAction("MobileToolbarPageSecurityInfo"));
// Dismiss the omnibox (if open).
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698