Chromium Code Reviews Chromium Code Reviews
Issue 2671983002:
ntp_tiles: Add UMA histograms to correlate icon type to position (Closed)
| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index 42d059db8002871cc8be8e10c9d95521e2b653e3..206ed8405161bf71d39493e6b7d1b8bdbc7fb29e 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -39786,7 +39786,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| <owner>newt@chromium.org</owner> |
| <summary> |
| Histogram for user clicks of the most visited thumbnails. The value is equal |
|
Marc Treib
2017/02/06 11:09:54
Also here s/thumbnails/tiles/ ?
mastiz
2017/02/07 08:27:41
Done, thx.
|
| - to the index of the thumbnail. |
| + to the index of the tile. |
| </summary> |
| </histogram> |
| @@ -39804,6 +39804,36 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| </summary> |
| </histogram> |
| +<histogram name="NewTabPage.MostVisitedClickIcon.Color" |
| + enum="MostVisitedTileIndex"> |
| + <owner>mastiz@chromium.org</owner> |
| + <summary> |
| + Histogram for clicks on the various most visited tiles using a fallback |
|
Marc Treib
2017/02/06 11:09:54
Why "various"?
nit: I'd remove the "Histogram for
mastiz
2017/02/07 08:27:41
Done.
|
| + color (as opposed to having an icon, or simply being gray). The value is |
| + equal to the index of the tile. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="NewTabPage.MostVisitedClickIcon.Gray" |
| + enum="MostVisitedTileIndex"> |
| + <owner>mastiz@chromium.org</owner> |
| + <summary> |
| + Histogram for clicks on the various most visited tiles displayed as gray (as |
| + opposed to having an icon, or a fallback color). The value is equal to the |
| + index of the tile. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="NewTabPage.MostVisitedClickIcon.Real" |
| + enum="MostVisitedTileIndex"> |
| + <owner>mastiz@chromium.org</owner> |
| + <summary> |
| + Histogram for clicks on the various most visited tiles displayed with the |
| + site's icon (as opposed using a fallback color or just gray). The value is |
| + equal to the index of the tile. |
| + </summary> |
| +</histogram> |
| + |
| <histogram name="NewTabPage.MostVisitedScheme" enum="NtpMostVisitedScheme"> |
| <obsolete> |
| Deprecated 2016-05. |
| @@ -40521,6 +40551,36 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| </summary> |
| </histogram> |
| +<histogram name="NewTabPage.SuggestionsImpressionIcon.Color" |
| + enum="MostVisitedTileIndex"> |
| + <owner>mastiz@chromium.org</owner> |
| + <summary> |
| + Histogram for impressions on the various most visited tiles using a fallback |
| + color (as opposed to having an icon, or simply being gray). The value is |
| + equal to the index of the tile. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="NewTabPage.SuggestionsImpressionIcon.Gray" |
| + enum="MostVisitedTileIndex"> |
| + <owner>mastiz@chromium.org</owner> |
| + <summary> |
| + Histogram for impressions on the various most visited tiles displayed as |
| + gray (as opposed to having an icon, or a fallback color). The value is equal |
| + to the index of the tile. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="NewTabPage.SuggestionsImpressionIcon.Real" |
| + enum="MostVisitedTileIndex"> |
| + <owner>mastiz@chromium.org</owner> |
| + <summary> |
| + Histogram for impressions on the various most visited tiles displayed with |
| + the site's icon (as opposed using a fallback color or just gray). The value |
| + is equal to the index of the tile. |
| + </summary> |
| +</histogram> |
| + |
| <histogram name="NewTabPage.SuggestionsType" enum="NtpSuggestionsType"> |
| <obsolete> |
| Deprecated 2016-07. |
