ntp_tiles: Add UMA histograms to correlate icon type to position

components/ntp_tiles/metrics_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/ntp_tiles/metrics.h"
 
 #include <stddef.h>
 
 #include <string>
 #include <vector>
@@ skipping 60 matching lines @@
               ElementsAre(base::Bucket(/*min=*/ICON_REAL, /*count=*/3),
                           base::Bucket(/*min=*/ICON_COLOR, /*count=*/2)));
   EXPECT_THAT(histogram_tester.GetAllSamples("NewTabPage.TileType.popular"),
               ElementsAre(base::Bucket(/*min=*/ICON_COLOR, /*count=*/1)));
   EXPECT_THAT(histogram_tester.GetAllSamples("NewTabPage.IconsReal"),
               ElementsAre(base::Bucket(/*min=*/4, /*count=*/1)));
   EXPECT_THAT(histogram_tester.GetAllSamples("NewTabPage.IconsColor"),
               ElementsAre(base::Bucket(/*min=*/3, /*count=*/1)));
   EXPECT_THAT(histogram_tester.GetAllSamples("NewTabPage.IconsGray"),
               ElementsAre(base::Bucket(/*min=*/1, /*count=*/1)));
+  EXPECT_THAT(histogram_tester.GetAllSamples(
+                  "NewTabPage.SuggestionsImpression.IconsReal"),
+              ElementsAre(base::Bucket(/*min=*/0, /*count=*/1),
+                          base::Bucket(/*min=*/1, /*count=*/1),
+                          base::Bucket(/*min=*/2, /*count=*/1),
+                          base::Bucket(/*min=*/5, /*count=*/1)));
+  EXPECT_THAT(histogram_tester.GetAllSamples(
+                  "NewTabPage.SuggestionsImpression.IconsColor"),
+              ElementsAre(base::Bucket(/*min=*/3, /*count=*/1),
+                          base::Bucket(/*min=*/4, /*count=*/1),
+                          base::Bucket(/*min=*/7, /*count=*/1)));
+  EXPECT_THAT(histogram_tester.GetAllSamples(
+                  "NewTabPage.SuggestionsImpression.IconsGray"),
+              ElementsAre(base::Bucket(/*min=*/6, /*count=*/1)));
 }
 
 TEST(RecordPageImpressionTest, ShouldRecordUmaForThumbnails) {
   base::HistogramTester histogram_tester;
   RecordPageImpression({{NTPTileSource::TOP_SITES, THUMBNAIL, GURL()},
                         {NTPTileSource::SUGGESTIONS_SERVICE, THUMBNAIL, GURL()},
                         {NTPTileSource::POPULAR, THUMBNAIL, GURL()}},
                        /*rappor_service=*/nullptr);
   EXPECT_THAT(histogram_tester.GetAllSamples("NewTabPage.NumberOfTiles"),
               ElementsAre(base::Bucket(/*min=*/3, /*count=*/1)));
@@ skipping 17 matching lines @@
   EXPECT_THAT(histogram_tester.GetAllSamples("NewTabPage.TileType.client"),
               IsEmpty());
   EXPECT_THAT(histogram_tester.GetAllSamples("NewTabPage.TileType.popular"),
               IsEmpty());
   EXPECT_THAT(histogram_tester.GetAllSamples("NewTabPage.IconsReal"),
               IsEmpty());
   EXPECT_THAT(histogram_tester.GetAllSamples("NewTabPage.IconsColor"),
               IsEmpty());
   EXPECT_THAT(histogram_tester.GetAllSamples("NewTabPage.IconsGray"),
               IsEmpty());
+  EXPECT_THAT(histogram_tester.GetAllSamples(
+                  "NewTabPage.SuggestionsImpression.IconsReal"),
+              IsEmpty());
+  EXPECT_THAT(histogram_tester.GetAllSamples(
+                  "NewTabPage.SuggestionsImpression.IconsColor"),
+              IsEmpty());
+  EXPECT_THAT(histogram_tester.GetAllSamples(
+                  "NewTabPage.SuggestionsImpression.IconsGray"),
+              IsEmpty());
+}
+
+TEST(RecordTileClickTest, ShouldRecordUma) {
+  base::HistogramTester histogram_tester;
+  RecordTileClick(3, NTPTileSource::TOP_SITES, ICON_REAL);
+  EXPECT_THAT(histogram_tester.GetAllSamples("NewTabPage.MostVisited.client"),
+              ElementsAre(base::Bucket(/*min=*/3, /*count=*/1)));
+  EXPECT_THAT(histogram_tester.GetAllSamples("NewTabPage.MostVisited.server"),
+              IsEmpty());
+  EXPECT_THAT(histogram_tester.GetAllSamples("NewTabPage.MostVisited.popular"),
+              IsEmpty());
+  EXPECT_THAT(
+      histogram_tester.GetAllSamples("NewTabPage.MostVisited.IconsReal"),
+      ElementsAre(base::Bucket(/*min=*/3, /*count=*/1)));
+  EXPECT_THAT(
+      histogram_tester.GetAllSamples("NewTabPage.MostVisited.IconsColor"),
+      IsEmpty());
+  EXPECT_THAT(
+      histogram_tester.GetAllSamples("NewTabPage.MostVisited.IconsGray"),
+      IsEmpty());
+}
+
+TEST(RecordTileClickTest, ShouldIgnoreThumbnails) {
+  base::HistogramTester histogram_tester;
+  RecordTileClick(3, NTPTileSource::TOP_SITES, THUMBNAIL);
+  EXPECT_THAT(
+      histogram_tester.GetAllSamples("NewTabPage.MostVisited.IconsReal"),
+      IsEmpty());
+  EXPECT_THAT(
+      histogram_tester.GetAllSamples("NewTabPage.MostVisited.IconsColor"),
+      IsEmpty());
+  EXPECT_THAT(
+      histogram_tester.GetAllSamples("NewTabPage.MostVisited.IconsGray"),
+      IsEmpty());
 }
 
 TEST(RecordPageImpressionTest, ShouldRecordRappor) {
   rappor::TestRapporServiceImpl rappor_service;
 
   RecordPageImpression(
       {{NTPTileSource::TOP_SITES, ICON_REAL, GURL("http://www.site1.com/")},
        {NTPTileSource::TOP_SITES, ICON_COLOR, GURL("http://www.site2.com/")},
        {NTPTileSource::TOP_SITES, ICON_DEFAULT, GURL("http://www.site3.com/")},
        {NTPTileSource::TOP_SITES, THUMBNAIL, GURL("http://www.site4.com/")}},
@@ skipping 26 matching lines @@
     EXPECT_TRUE(rappor_service.GetRecordedSampleForMetric(
         "NTP.SuggestionsImpressions.IconsGray", &sample, &type));
     EXPECT_EQ("site3.com", sample);
     EXPECT_EQ(rappor::ETLD_PLUS_ONE_RAPPOR_TYPE, type);
   }
 }
 
 }  // namespace
 }  // namespace metrics
 }  // namespace ntp_tiles