third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.cpp - Issue 2671933002: Migrate WTF::HashMap::add() to ::insert()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.cpp

Issue 2671933002: Migrate WTF::HashMap::add() to ::insert() (Closed)

Patch Set: rebase, add TODOs Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/OffscreenCanvasPlaceholder.cpp ('k') | third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.cpp b/third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.cpp

index f8264990f93783d3b6418e90f75398559d19cb27..eb65a9882d13c85b03f909a18b0e084ecde9318e 100644

--- a/third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.cpp

+++ b/third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.cpp

@@ -53,9 +53,10 @@ void DisplayItemClient::beginShouldKeepAlive(const void* owner) const {

if (!displayItemClientsShouldKeepAlive)

displayItemClientsShouldKeepAlive =

new HashMap<const void*, HashMap<const DisplayItemClient*, String>>();

- auto addResult = displayItemClientsShouldKeepAlive

- ->add(owner, HashMap<const DisplayItemClient*, String>())

- .storedValue->value.add(this, "");

+ auto addResult =

+ displayItemClientsShouldKeepAlive

+ ->insert(owner, HashMap<const DisplayItemClient*, String>())

+ .storedValue->value.insert(this, "");

if (addResult.isNewEntry)

addResult.storedValue->value = debugName();

}