third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp - Issue 2671933002: Migrate WTF::HashMap::add() to ::insert()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp

Issue 2671933002: Migrate WTF::HashMap::add() to ::insert() (Closed)

Patch Set: rebase, add TODOs Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp b/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp

index a9e30d30d5c521da9e455e63a30fab78f21a172e..e83296a135a594df65d9825ab7e6d0f917c76fcb 100644

--- a/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp

+++ b/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp

@@ -146,7 +146,7 @@ static PassRefPtr<HbFontCacheEntry> createHbFontCacheEntry(hb_face_t*);

HarfBuzzFace::HarfBuzzFace(FontPlatformData* platformData, uint64_t uniqueID)

: m_platformData(platformData), m_uniqueID(uniqueID) {

HarfBuzzFontCache::AddResult result =

- harfBuzzFontCache()->add(m_uniqueID, nullptr);

+ harfBuzzFontCache()->insert(m_uniqueID, nullptr);

if (result.isNewEntry) {

HbFaceUniquePtr face(createFace());

result.storedValue->value = createHbFontCacheEntry(face.get());