third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp - Issue 2671933002: Migrate WTF::HashMap::add() to ::insert()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp

Issue 2671933002: Migrate WTF::HashMap::add() to ::insert() (Closed)

Patch Set: rebase, add TODOs Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/peerconnection/RTCStatsResponse.cpp ('k') | third_party/WebKit/Source/modules/webdatabase/QuotaTracker.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp

diff --git a/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp b/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp

index 6ed9d88efe63bc51e87baadb746a0a387964353a..9872053f3470ebb8fe113d2c3a49e2707b65dc35 100644

--- a/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp

+++ b/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp

@@ -83,10 +83,11 @@ ScriptPromise RemotePlayback::watchAvailability(

int id;

do {

id = getExecutionContext()->circularSequentialID();

- } while (!m_availabilityCallbacks

- .add(id, TraceWrapperMember<RemotePlaybackAvailabilityCallback>(

- this, callback))

- .isNewEntry);

+ } while (

+ !m_availabilityCallbacks

+ .insert(id, TraceWrapperMember<RemotePlaybackAvailabilityCallback>(

+ this, callback))

+ .isNewEntry);

// Report the current availability via the callback.

getExecutionContext()->postTask(