third_party/WebKit/Source/modules/peerconnection/RTCStatsResponse.cpp - Issue 2671933002: Migrate WTF::HashMap::add() to ::insert()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/peerconnection/RTCStatsResponse.cpp

Issue 2671933002: Migrate WTF::HashMap::add() to ::insert() (Closed)

Patch Set: rebase, add TODOs Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/peerconnection/RTCLegacyStatsReport.cpp ('k') | third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/peerconnection/RTCStatsResponse.cpp

diff --git a/third_party/WebKit/Source/modules/peerconnection/RTCStatsResponse.cpp b/third_party/WebKit/Source/modules/peerconnection/RTCStatsResponse.cpp

index 712e20db258efbd04a4a6a90ec9cd41783de159a..ca4fc4ce5e86df8e5f25c0eaf29644171deb3d77 100644

--- a/third_party/WebKit/Source/modules/peerconnection/RTCStatsResponse.cpp

+++ b/third_party/WebKit/Source/modules/peerconnection/RTCStatsResponse.cpp

@@ -41,7 +41,7 @@ RTCLegacyStatsReport* RTCStatsResponse::namedItem(const AtomicString& name) {

void RTCStatsResponse::addStats(const WebRTCLegacyStats& stats) {

m_result.push_back(RTCLegacyStatsReport::create(stats.id(), stats.type(),

stats.timestamp()));

- m_idmap.add(stats.id(), m_result.size() - 1);

+ m_idmap.insert(stats.id(), m_result.size() - 1);

RTCLegacyStatsReport* report = m_result[m_result.size() - 1].get();

for (std::unique_ptr<WebRTCLegacyStatsMemberIterator> member(