third_party/WebKit/Source/modules/indexeddb/IDBObserverChanges.cpp - Issue 2671933002: Migrate WTF::HashMap::add() to ::insert()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/indexeddb/IDBObserverChanges.cpp

Issue 2671933002: Migrate WTF::HashMap::add() to ::insert() (Closed)

Patch Set: rebase, add TODOs Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/indexeddb/IDBObserverChanges.cpp

diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBObserverChanges.cpp b/third_party/WebKit/Source/modules/indexeddb/IDBObserverChanges.cpp

index f0a8ba971751e9caa7e9f391580ee6a94a56b937..45f62cd668c18643cc37944a5618d7eaf2c6b1e2 100644

--- a/third_party/WebKit/Source/modules/indexeddb/IDBObserverChanges.cpp

+++ b/third_party/WebKit/Source/modules/indexeddb/IDBObserverChanges.cpp

@@ -60,8 +60,8 @@ void IDBObserverChanges::extractChanges(

// TODO(dmurph): Avoid getting and setting repeated times.

for (const auto& idx : observationIndices) {

m_records

- .add(observations[idx].objectStoreId,

- HeapVector<Member<IDBObservation>>())

+ .insert(observations[idx].objectStoreId,

+ HeapVector<Member<IDBObservation>>())

.storedValue->value.push_back(

IDBObservation::create(observations[idx]));

}