third_party/WebKit/Source/modules/bluetooth/BluetoothAttributeInstanceMap.cpp - Issue 2671933002: Migrate WTF::HashMap::add() to ::insert()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/bluetooth/BluetoothAttributeInstanceMap.cpp

Issue 2671933002: Migrate WTF::HashMap::add() to ::insert() (Closed)

Patch Set: rebase, add TODOs Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/workers/ParentFrameTaskRunners.cpp ('k') | third_party/WebKit/Source/modules/bluetooth/BluetoothUUID.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/bluetooth/BluetoothAttributeInstanceMap.cpp

diff --git a/third_party/WebKit/Source/modules/bluetooth/BluetoothAttributeInstanceMap.cpp b/third_party/WebKit/Source/modules/bluetooth/BluetoothAttributeInstanceMap.cpp

index 1326f66c554bf09e694ac5d5cc2b3d92bf724245..005d4c720827e71ab4db9dbfe26d42976894c83f 100644

--- a/third_party/WebKit/Source/modules/bluetooth/BluetoothAttributeInstanceMap.cpp

+++ b/third_party/WebKit/Source/modules/bluetooth/BluetoothAttributeInstanceMap.cpp

@@ -27,7 +27,7 @@ BluetoothAttributeInstanceMap::getOrCreateRemoteGATTService(

if (!service) {

service = new BluetoothRemoteGATTService(

std::move(remoteGATTService), isPrimary, deviceInstanceId, m_device);

- m_serviceIdToObject.add(serviceInstanceId, service);

+ m_serviceIdToObject.insert(serviceInstanceId, service);

}

return service;

@@ -51,7 +51,7 @@ BluetoothAttributeInstanceMap::getOrCreateRemoteGATTCharacteristic(

if (!characteristic) {

characteristic = BluetoothRemoteGATTCharacteristic::create(

context, std::move(remoteGATTCharacteristic), service, m_device);

- m_characteristicIdToObject.add(instanceId, characteristic);

+ m_characteristicIdToObject.insert(instanceId, characteristic);

}

return characteristic;

@@ -75,7 +75,7 @@ BluetoothAttributeInstanceMap::getOrCreateBluetoothRemoteGATTDescriptor(

result =

new BluetoothRemoteGATTDescriptor(std::move(descriptor), characteristic);

- m_descriptorIdToObject.add(instanceId, result);

+ m_descriptorIdToObject.insert(instanceId, result);

return result;

}