third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.cpp - Issue 2671933002: Migrate WTF::HashMap::add() to ::insert()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.cpp

Issue 2671933002: Migrate WTF::HashMap::add() to ::insert() (Closed)

Patch Set: rebase, add TODOs Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceGradient.cpp ('k') | third_party/WebKit/Source/core/page/NetworkStateNotifier.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.cpp b/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.cpp

index 6a8bab4ad93c73970242af170e117144b420c465..36f2aab9cf62db65e9e975960539798f9953eb41 100644

--- a/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.cpp

@@ -150,7 +150,7 @@ void SVGTextLayoutAttributesBuilder::buildCharacterDataMap(

// Handle x/y default attributes.

SVGCharacterData& data =

- m_characterDataMap.add(1, SVGCharacterData()).storedValue->value;

+ m_characterDataMap.insert(1, SVGCharacterData()).storedValue->value;

if (!data.hasX())

data.x = 0;

if (!data.hasY())

@@ -234,7 +234,7 @@ void SVGTextLayoutAttributesBuilder::fillCharacterDataMap(

AttributeListsIterator attrLists(position.element);

for (unsigned i = 0; attrLists.hasAttributes() && i < position.length; ++i) {

SVGCharacterData& data =

- m_characterDataMap.add(position.start + i + 1, SVGCharacterData())

+ m_characterDataMap.insert(position.start + i + 1, SVGCharacterData())

.storedValue->value;

attrLists.updateCharacterData(i, data);

}