Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/WindowProxyManager.cpp

Issue 2671933002: Migrate WTF::HashMap::add() to ::insert() (Closed)
Patch Set: rebase, add TODOs Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/WindowProxyManager.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/WindowProxyManager.cpp b/third_party/WebKit/Source/bindings/core/v8/WindowProxyManager.cpp
index 8e7a752720b45b56d834a48b14ccebe4d2bc6a43..43350caabe273ee755cb9bfda43f13cfea0302c9 100644
--- a/third_party/WebKit/Source/bindings/core/v8/WindowProxyManager.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/WindowProxyManager.cpp
@@ -59,10 +59,10 @@ void WindowProxyManagerBase::clearForNavigation() {
void WindowProxyManagerBase::releaseGlobals(
HashMap<DOMWrapperWorld*, v8::Local<v8::Object>>& map) {
- map.add(&m_windowProxy->world(), m_windowProxy->releaseGlobal());
+ map.insert(&m_windowProxy->world(), m_windowProxy->releaseGlobal());
for (auto& entry : m_isolatedWorlds)
- map.add(&entry.value->world(),
- windowProxy(entry.value->world())->releaseGlobal());
+ map.insert(&entry.value->world(),
+ windowProxy(entry.value->world())->releaseGlobal());
}
void WindowProxyManagerBase::setGlobals(

Powered by Google App Engine
This is Rietveld 408576698