Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: ash/common/shelf/shelf_application_menu_model.h

Issue 2671923002: mash: Cleanup ash shelf application menu code. (Closed)
Patch Set: Fix tests; cleanup. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/common/shelf/shelf_application_menu_model.h
diff --git a/ash/common/shelf/shelf_application_menu_model.h b/ash/common/shelf/shelf_application_menu_model.h
new file mode 100644
index 0000000000000000000000000000000000000000..653e8cb1f7d9250f1d9d1fa156ba2064237363c5
--- /dev/null
+++ b/ash/common/shelf/shelf_application_menu_model.h
@@ -0,0 +1,50 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef ASH_COMMON_SHELF_SHELF_APPLICATION_MENU_MODEL_H_
+#define ASH_COMMON_SHELF_SHELF_APPLICATION_MENU_MODEL_H_
+
+#include <memory>
+#include <vector>
+
+#include "ash/ash_export.h"
+#include "ash/public/cpp/shelf_application_menu_item.h"
+#include "base/macros.h"
+#include "ui/base/models/simple_menu_model.h"
+
+class ShelfApplicationMenuModelTestAPI;
+
+namespace ash {
+
+// A menu model listing open applications associated with a shelf item.
James Cook 2017/02/06 17:30:21 optional: A little piece of ASCII art showing what
msw 2017/02/07 09:12:00 Done.
+class ASH_EXPORT ShelfApplicationMenuModel
+ : public ui::SimpleMenuModel,
+ public ui::SimpleMenuModel::Delegate {
+ public:
+ // Makes a menu with a |title|, separators, and the specified |items|.
+ ShelfApplicationMenuModel(const base::string16& title,
+ ShelfApplicationMenuItems items);
+ ~ShelfApplicationMenuModel() override;
+
+ // ui::SimpleMenuModel::Delegate:
+ bool IsCommandIdChecked(int command_id) const override;
+ bool IsCommandIdEnabled(int command_id) const override;
+ void ExecuteCommand(int command_id, int event_flags) override;
+
+ private:
+ friend class ShelfApplicationMenuModelTestAPI;
+
+ // Records UMA metrics when a menu item is selected.
+ void RecordMenuItemSelectedMetrics(int command_id,
+ int num_menu_items_enabled);
+
+ // The list of menu items as returned from the shelf item's controller.
+ ShelfApplicationMenuItems items_;
+
+ DISALLOW_COPY_AND_ASSIGN(ShelfApplicationMenuModel);
+};
+
+} // namespace ash
+
+#endif // ASH_COMMON_SHELF_SHELF_APPLICATION_MENU_MODEL_H_

Powered by Google App Engine
This is Rietveld 408576698