Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_tab.h

Issue 2671923002: mash: Cleanup ash shelf application menu code. (Closed)
Patch Set: Add comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_tab.h
diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_tab.h b/chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_tab.h
index 699e5d4c32139dc911994daf300fd2ceb03149ec..00e8336f6e749a39ab6c9b97a96d4a7355a7803d 100644
--- a/chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_tab.h
+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_tab.h
@@ -5,27 +5,24 @@
#ifndef CHROME_BROWSER_UI_ASH_LAUNCHER_CHROME_LAUNCHER_APP_MENU_ITEM_TAB_H_
#define CHROME_BROWSER_UI_ASH_LAUNCHER_CHROME_LAUNCHER_APP_MENU_ITEM_TAB_H_
+#include "ash/public/cpp/shelf_application_menu_item.h"
#include "base/macros.h"
#include "base/strings/string16.h"
-#include "chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item.h"
#include "content/public/browser/web_contents_observer.h"
namespace content{
class WebContents;
}
-// A menu item controller for a running browser tab. It gets created when an
-// application/tab list gets created. It's main purpose is to add the
-// activation method to the |ChromeLauncherAppMenuItem| class.
-class ChromeLauncherAppMenuItemTab
- : public ChromeLauncherAppMenuItem,
- public content::WebContentsObserver {
+// A shelf application menu item for a running browser tab.
+class ChromeLauncherAppMenuItemTab : public ash::ShelfApplicationMenuItem,
+ public content::WebContentsObserver {
public:
ChromeLauncherAppMenuItemTab(const base::string16 title,
const gfx::Image* icon,
- content::WebContents* content,
- bool has_leading_separator);
- bool IsEnabled() const override;
+ content::WebContents* content);
+
+ // ash::ShelfApplicationMenuItem:
void Execute(int event_flags) override;
private:

Powered by Google App Engine
This is Rietveld 408576698