Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_browser.h

Issue 2671923002: mash: Cleanup ash shelf application menu code. (Closed)
Patch Set: Add comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_browser.h
diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_browser.h b/chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_browser.h
index eca80ab314589a7fdc8be34c7a5baf081fa017f8..f1d70786d5368a5aa96da4c44d3c0d8fa20d5711 100644
--- a/chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_browser.h
+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_browser.h
@@ -5,27 +5,23 @@
#ifndef CHROME_BROWSER_UI_ASH_LAUNCHER_CHROME_LAUNCHER_APP_MENU_ITEM_BROWSER_H_
#define CHROME_BROWSER_UI_ASH_LAUNCHER_CHROME_LAUNCHER_APP_MENU_ITEM_BROWSER_H_
+#include "ash/public/cpp/shelf_application_menu_item.h"
#include "base/macros.h"
-#include "base/values.h"
-#include "chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item.h"
#include "content/public/browser/notification_observer.h"
#include "content/public/browser/notification_registrar.h"
class Browser;
-// A menu item controller for a running browser. It gets created when an
-// application list gets created. It's main purpose is to add the activation
-// method to the |ChromeLauncherAppMenuItem| class.
-class ChromeLauncherAppMenuItemBrowser : public content::NotificationObserver,
- public ChromeLauncherAppMenuItem {
+// A shelf application menu item for a running browser.
+class ChromeLauncherAppMenuItemBrowser : public ash::ShelfApplicationMenuItem,
+ public content::NotificationObserver {
public:
ChromeLauncherAppMenuItemBrowser(const base::string16 title,
const gfx::Image* icon,
- Browser* browser,
- bool has_leading_separator);
+ Browser* browser);
~ChromeLauncherAppMenuItemBrowser() override;
- bool IsEnabled() const override;
+ // ash::ShelfApplicationMenuItem:
void Execute(int event_flags) override;
private:

Powered by Google App Engine
This is Rietveld 408576698