Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3036)

Unified Diff: chrome/browser/ui/ash/launcher/arc_app_window_launcher_item_controller.cc

Issue 2671923002: mash: Cleanup ash shelf application menu code. (Closed)
Patch Set: Add comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/ash/launcher/arc_app_window_launcher_item_controller.cc
diff --git a/chrome/browser/ui/ash/launcher/arc_app_window_launcher_item_controller.cc b/chrome/browser/ui/ash/launcher/arc_app_window_launcher_item_controller.cc
index 8255135481d1e503c4c3801f5bc9ad6a70e9d881..12da626b1fd9047d4d486c634975487b0fdcc38a 100644
--- a/chrome/browser/ui/ash/launcher/arc_app_window_launcher_item_controller.cc
+++ b/chrome/browser/ui/ash/launcher/arc_app_window_launcher_item_controller.cc
@@ -12,7 +12,6 @@
#include "chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.h"
#include "chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_v2app.h"
#include "chrome/browser/ui/ash/launcher/chrome_launcher_controller.h"
-#include "chrome/browser/ui/ash/launcher/launcher_application_menu_item_model.h"
#include "chrome/browser/ui/ash/launcher/launcher_controller_helper.h"
#include "ui/aura/window.h"
#include "ui/base/base_window.h"
@@ -50,10 +49,9 @@ ArcAppWindowLauncherItemController::ItemSelected(const ui::Event& event) {
}
}
-ChromeLauncherAppMenuItems
-ArcAppWindowLauncherItemController::GetApplicationList(int event_flags) {
- ChromeLauncherAppMenuItems items =
- AppWindowLauncherItemController::GetApplicationList(event_flags);
+ash::ShelfAppMenuItemList ArcAppWindowLauncherItemController::GetAppMenuItems(
+ int event_flags) {
+ ash::ShelfAppMenuItemList items;
base::string16 app_title = LauncherControllerHelper::GetAppTitle(
launcher_controller()->profile(), app_id());
for (auto it = windows().begin(); it != windows().end(); ++it) {
@@ -64,8 +62,7 @@ ArcAppWindowLauncherItemController::GetApplicationList(int event_flags) {
items.push_back(base::MakeUnique<ChromeLauncherAppMenuItemV2App>(
((window && !window->GetTitle().empty()) ? window->GetTitle()
: app_title),
- &image, app_id(), launcher_controller(), i,
- i == 0 /* has_leading_separator */));
+ &image, app_id(), launcher_controller(), i));
}
return items;
}

Powered by Google App Engine
This is Rietveld 408576698