Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: ash/shell/window_watcher_shelf_item_delegate.cc

Issue 2671923002: mash: Cleanup ash shelf application menu code. (Closed)
Patch Set: Add comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ash/shell/window_watcher_shelf_item_delegate.h ('k') | chrome/browser/ui/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/shell/window_watcher_shelf_item_delegate.h" 5 #include "ash/shell/window_watcher_shelf_item_delegate.h"
6 6
7 #include "ash/shell/window_watcher.h" 7 #include "ash/shell/window_watcher.h"
8 #include "ash/wm/window_util.h" 8 #include "ash/wm/window_util.h"
9 #include "ui/aura/window.h" 9 #include "ui/aura/window.h"
10 10
(...skipping 13 matching lines...) Expand all
24 ShelfItemDelegate::PerformedAction WindowWatcherShelfItemDelegate::ItemSelected( 24 ShelfItemDelegate::PerformedAction WindowWatcherShelfItemDelegate::ItemSelected(
25 const ui::Event& event) { 25 const ui::Event& event) {
26 aura::Window* window = watcher_->GetWindowByID(id_); 26 aura::Window* window = watcher_->GetWindowByID(id_);
27 if (window->type() == ui::wm::WINDOW_TYPE_PANEL) 27 if (window->type() == ui::wm::WINDOW_TYPE_PANEL)
28 wm::MoveWindowToEventRoot(window, event); 28 wm::MoveWindowToEventRoot(window, event);
29 window->Show(); 29 window->Show();
30 wm::ActivateWindow(window); 30 wm::ActivateWindow(window);
31 return kExistingWindowActivated; 31 return kExistingWindowActivated;
32 } 32 }
33 33
34 ui::SimpleMenuModel* WindowWatcherShelfItemDelegate::CreateApplicationMenu( 34 ShelfAppMenuItemList WindowWatcherShelfItemDelegate::GetAppMenuItems(
35 int event_flags) { 35 int event_flags) {
36 return nullptr; 36 // Return an empty item list to avoid showing an application menu.
37 return ShelfAppMenuItemList();
37 } 38 }
38 39
39 void WindowWatcherShelfItemDelegate::Close() {} 40 void WindowWatcherShelfItemDelegate::Close() {}
40 41
41 } // namespace shell 42 } // namespace shell
42 } // namespace ash 43 } // namespace ash
OLDNEW
« no previous file with comments | « ash/shell/window_watcher_shelf_item_delegate.h ('k') | chrome/browser/ui/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698