Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 2671913002: Update status for analyze_libraries suite, and make it work with --use-sdk (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index a5569121f6f467b2ddfa135b7807d6f8f057c173..76b3c326083498a80664fd439cd248c496361416 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -1962,8 +1962,11 @@ class DartcCompilationTestSuite extends StandardTestSuite {
}
class AnalyzeLibraryTestSuite extends DartcCompilationTestSuite {
+ static String libraryPath(Map configuration) =>
+ configuration['use_sdk'] ? '${TestUtils.buildDir(configuration)}/dart-sdk' : 'sdk';
+
AnalyzeLibraryTestSuite(Map configuration)
- : super(configuration, 'analyze_library', 'sdk', ['lib'],
+ : super(configuration, 'analyze_library', libraryPath(configuration), ['lib'],
['tests/lib/analyzer/analyze_library.status']);
List<String> additionalOptions(Path filePath, {bool showSdkWarnings}) {
« tests/lib/analyzer/analyze_library.status ('K') | « tests/lib/analyzer/analyze_library.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698