Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 2671913002: Update status for analyze_libraries suite, and make it work with --use-sdk (Closed)

Created:
3 years, 10 months ago by Bill Hesse
Modified:
3 years, 10 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, Leaf, Brian Wilkerson
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update status for analyze_libraries suite, and make it work with --use-sdk BUG=https://github.com/dart-lang/sdk/issues/28620 R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/33e89e66becd1be4788a5eb78a39d9f419734561

Patch Set 1 #

Total comments: 1

Patch Set 2 : Update status for analyze_libraries suite, and make it work with --use-sdk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -13 lines) Patch
M tests/lib/analyzer/analyze_library.status View 1 chunk +15 lines, -11 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 1 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bill Hesse
https://codereview.chromium.org/2671913002/diff/1/tests/lib/analyzer/analyze_library.status File tests/lib/analyzer/analyze_library.status (right): https://codereview.chromium.org/2671913002/diff/1/tests/lib/analyzer/analyze_library.status#newcode12 tests/lib/analyzer/analyze_library.status:12: lib/_blink/dartium/_blink_dartium: StaticWarning # Undefined Creates and Returns classes Just ...
3 years, 10 months ago (2017-02-03 01:51:55 UTC) #2
Florian Schneider
lgtm
3 years, 10 months ago (2017-02-03 02:19:48 UTC) #3
Bill Hesse
3 years, 10 months ago (2017-02-03 02:21:05 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
33e89e66becd1be4788a5eb78a39d9f419734561 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698